Clean up SkBitmapOperations.

Clean up SkBitmapOperations.

- Remove CreateResizedBitmap since there is a better
  skia::ImageOperations::Resize;
- Update CreateDropShadow to use ShadowValue for shadow definition;

BUG=None.
TEST=None. All should work as before this change.

R=asvitkine@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139162

[Alexei Svitkine (slow), 2012-05-25 18:16:06]

http://codereview.chromium.org/10453035/diff/1/ui/app_list/app_list_item_view.cc
File ui/app_list/app_list_item_view.cc (right):

http://codereview.chromium.org/10453035/diff/1/ui/app_list/app_list_item_view...
ui/app_list/app_list_item_view.cc:151: &kShadows[arraysize(kShadows)]);
I think initializing with (kShadows, kShadows + arraysize(kShadows)) is a bit
cleaner. Also, maybe just inline it into the call below.

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.cc
File ui/gfx/skbitmap_operations.cc (right):

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.cc#...
ui/gfx/skbitmap_operations.cc:794: shadow.color());
Indentation looks wrong. Suggest moving everything after = on a new line, if it
doesn't fit.

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.h
File ui/gfx/skbitmap_operations.h (right):

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.h#n...
ui/gfx/skbitmap_operations.h:113: // config.
Please update the comment (it references things like |shadow_count| that no
longer exist).

[xiyuan, 2012-05-25 19:34:01]

- All comments in #1 are addressed;
- Added a "typedef std::vector<ShadowValue> ShadowValues" in shadow_value.h and
updated related files;

Please take another look.
Thanks.

http://codereview.chromium.org/10453035/diff/1/ui/app_list/app_list_item_view.cc
File ui/app_list/app_list_item_view.cc (right):

http://codereview.chromium.org/10453035/diff/1/ui/app_list/app_list_item_view...
ui/app_list/app_list_item_view.cc:151: &kShadows[arraysize(kShadows)]);
On 2012/05/25 18:16:06, Alexei Svitkine wrote:
> I think initializing with (kShadows, kShadows + arraysize(kShadows)) is a bit
> cleaner. Also, maybe just inline it into the call below.

Done.

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.cc
File ui/gfx/skbitmap_operations.cc (right):

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.cc#...
ui/gfx/skbitmap_operations.cc:794: shadow.color());
On 2012/05/25 18:16:06, Alexei Svitkine wrote:
> Indentation looks wrong. Suggest moving everything after = on a new line, if
it
> doesn't fit.

Done.

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.h
File ui/gfx/skbitmap_operations.h (right):

http://codereview.chromium.org/10453035/diff/1/ui/gfx/skbitmap_operations.h#n...
ui/gfx/skbitmap_operations.h:113: // config.
On 2012/05/25 18:16:06, Alexei Svitkine wrote:
> Please update the comment (it references things like |shadow_count| that no
> longer exist).

Done. Totally blind. Thanks for pointing out. :p

[Alexei Svitkine (slow), 2012-05-25 19:45:39]

LGTM

[xiyuan, 2012-05-25 19:52:22]

On 2012/05/25 19:45:39, Alexei Svitkine wrote:
> LGTM

Sorry, just found that I have more std::vector<ShadowValue> in other files such
as render_text.h and skia_util.h (added there yesterday). Should I change them
to gfx::ShadowValues too?

[Alexei Svitkine (slow), 2012-05-25 20:06:17]

On 2012/05/25 19:52:22, xiyuan wrote:
> On 2012/05/25 19:45:39, Alexei Svitkine wrote:
> > LGTM
> 
> Sorry, just found that I have more std::vector<ShadowValue> in other files
such
> as render_text.h and skia_util.h (added there yesterday). Should I change them
> to gfx::ShadowValues too?

How about a followup CL?

[xiyuan, 2012-05-25 20:07:18]

On 2012/05/25 20:06:17, Alexei Svitkine wrote:
> On 2012/05/25 19:52:22, xiyuan wrote:
> > On 2012/05/25 19:45:39, Alexei Svitkine wrote:
> > > LGTM
> > 
> > Sorry, just found that I have more std::vector<ShadowValue> in other files
> such
> > as render_text.h and skia_util.h (added there yesterday). Should I change
them
> > to gfx::ShadowValues too?
> 
> How about a followup CL?

Sounds good.

[xiyuan, 2012-05-25 20:18:27]

+sky for ash owner's review.

[sky, 2012-05-25 20:33:57]

LGTM

[commit-bot: I haz the power, 2012-05-25 22:17:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10453035/11002

[commit-bot: I haz the power, 2012-05-26 00:29:18]

Change committed as 139162