Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 1045203003: MIPS64: [turbofan] Add backend support for float32 operations. (Closed)

Created:
5 years, 8 months ago by akos.palfi.imgtec
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS64: [turbofan] Add backend support for float32 operations. Port 8dad78cdbd21c2cd02d6e0645313bd4b9983c78e Original commit message: This adds the basics necessary to support float32 operations in TurboFan. The actual functionality required to detect safe float32 operations will be added based on this later. Therefore this does not affect production code except for some cleanup/refactoring. In detail, this patchset contains the following features: - Add support for float32 operations to arm, arm64, ia32 and x64 backends. - Add float32 machine operators. - Add support for float32 constants to simplified lowering. - Handle float32 representation for phis in simplified lowering. In addition, contains the following (related) cleanups: - Fix/unify naming of backend instructions. - Use AVX comparisons when available. - Extend ArchOpcodeField to 9 bits (required for arm64). - Refactor some code duplication in instruction selectors. BUG= Committed: https://crrev.com/df40d51e7dbceb273a340bd8300f3180047409d7 Cr-Commit-Position: refs/heads/master@{#27534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -57 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 4 chunks +78 lines, -4 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 10 chunks +80 lines, -25 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 3 chunks +13 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 4 chunks +36 lines, -22 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 2 chunks +54 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 8 months ago (2015-03-31 11:03:01 UTC) #2
balazs.kilvady
LGTM.
5 years, 8 months ago (2015-03-31 11:04:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045203003/1
5 years, 8 months ago (2015-03-31 11:05:58 UTC) #5
dusmil.imgtec
LGTM.
5 years, 8 months ago (2015-03-31 11:12:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 11:27:11 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 11:27:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df40d51e7dbceb273a340bd8300f3180047409d7
Cr-Commit-Position: refs/heads/master@{#27534}

Powered by Google App Engine
This is Rietveld 408576698