Fix blacklisting for desktop infobars.

chrome/browser/password_manager/save_password_infobar_delegate.h

Index: chrome/browser/password_manager/save_password_infobar_delegate.h
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.h b/chrome/browser/password_manager/save_password_infobar_delegate.h
index 4dd0b4d0684bfc28cbef21d55f54bc27df12a138..e28932da9f668fcd1e105fe20be9edc28c32412b 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate.h
+++ b/chrome/browser/password_manager/save_password_infobar_delegate.h
@@ -40,6 +40,16 @@ class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
       const std::string& uma_histogram_suffix,
       password_manager::CredentialSourceType source_type);
 
+#if defined(UNIT_TEST)

[vabr (Chromium), 2015/04/02 13:32:16]

As an alternative -- what about making the SavePasswordInfoBarDelegate
constructor protected, with a comment that it is for tests, and creating a
sub-class of SavePasswordInfoBarDelegate in your unittest with the sole purpose
to expose the constructor through it?

I would prefer that to adding stuff and #ifdefs to the production header.

[melandory, 2015/04/02 15:49:17]

I'll add TODO.

+  static scoped_ptr<ConfirmInfoBarDelegate> Create(
+      scoped_ptr<password_manager::PasswordFormManager> form_to_save,
+      const std::string& uma_histogram_suffix,

[vabr (Chromium), 2015/04/02 13:32:16]

I don't think you need this argument, just hard-code a std::string().

[melandory, 2015/04/02 15:49:17]

Done.

+      password_manager::CredentialSourceType source_type) {
+    return scoped_ptr<ConfirmInfoBarDelegate>(new SavePasswordInfoBarDelegate(
+        form_to_save.Pass(), uma_histogram_suffix, source_type));
+  }
+#endif
+
   ~SavePasswordInfoBarDelegate() override;
 
   // If the infobar was triggered by the Credential management API, then on