Fix blacklisting for desktop infobars.

chrome/browser/password_manager/save_password_infobar_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/timer/elapsed_timer.h"
@@ skipping 22 matching lines @@
   // for |web_contents|.  |uma_histogram_suffix| is empty, or one of the
   // "group_X" suffixes used in the histogram names for infobar usage reporting;
   // if empty, the usage is not reported, otherwise the suffix is used to choose
   // the right histogram.
   static void Create(
       content::WebContents* web_contents,
       scoped_ptr<password_manager::PasswordFormManager> form_to_save,
       const std::string& uma_histogram_suffix,
       password_manager::CredentialSourceType source_type);
 
+#if defined(UNIT_TEST)

[vabr (Chromium), 2015/04/02 13:32:16]

As an alternative -- what about making the SavePasswordInfoBarDelegate
constructor protected, with a comment that it is for tests, and creating a
sub-class of SavePasswordInfoBarDelegate in your unittest with the sole purpose
to expose the constructor through it?

I would prefer that to adding stuff and #ifdefs to the production header.

[melandory, 2015/04/02 15:49:17]

I'll add TODO.

+  static scoped_ptr<ConfirmInfoBarDelegate> Create(
+      scoped_ptr<password_manager::PasswordFormManager> form_to_save,
+      const std::string& uma_histogram_suffix,

[vabr (Chromium), 2015/04/02 13:32:16]

I don't think you need this argument, just hard-code a std::string().

[melandory, 2015/04/02 15:49:17]

Done.

+      password_manager::CredentialSourceType source_type) {
+    return scoped_ptr<ConfirmInfoBarDelegate>(new SavePasswordInfoBarDelegate(
+        form_to_save.Pass(), uma_histogram_suffix, source_type));
+  }
+#endif
+
   ~SavePasswordInfoBarDelegate() override;
 
   // If the infobar was triggered by the Credential management API, then on
   // Android it should display the "More" button.
   bool ShouldShowMoreButton();
 
   // ConfirmInfoBarDelegate:
   Type GetInfoBarType() const override;
   InfoBarAutomationType GetInfoBarAutomationType() const override;
   int GetIconID() const override;
@@ skipping 26 matching lines @@
   const std::string uma_histogram_suffix_;
 
   // Records source from where infobar was triggered.
   // Infobar appearance (title, buttons) depends on value of this parameter.
   password_manager::CredentialSourceType source_type_;
 
   DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBarDelegate);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_