Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 1045173003: Fix blacklisting for desktop infobars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/password_manager/save_password_infobar_delegate.h ('K') | « chrome/browser/password_manager/save_password_infobar_delegate.h ('k') | chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/save_password_infobar_delegate.cc
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc
index 09e78ccf4a6564d692dad66cc9bdcc2fccc5a2e7..19d40ec6e5bc2cb2a654cf297902396ae3eaa53c 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc
+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc
@@ -150,10 +150,10 @@ bool SavePasswordInfoBarDelegate::Cancel() {
DCHECK(form_to_save_.get());
if (source_type_ ==
password_manager::CredentialSourceType::CREDENTIAL_SOURCE_API) {
+ InfoBarDismissed();
+ } else {
form_to_save_->PermanentlyBlacklist();
infobar_response_ = password_manager::metrics_util::NEVER_REMEMBER_PASSWORD;
- } else {
- InfoBarDismissed();
}
return true;
}
« chrome/browser/password_manager/save_password_infobar_delegate.h ('K') | « chrome/browser/password_manager/save_password_infobar_delegate.h ('k') | chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698