Issue 1043953003: Timeline: do not cache TimelineView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1043953003: Timeline: do not cache TimelineView (Closed)

Created:
5 years, 8 months ago by caseq

Modified:
5 years, 8 months ago

Reviewers:
alph, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Timeline: do not cache TimelineView We don't reset views other than active ones when new recording is done and generally treat views as disposable upon mode change, so don't cache TimelineView, rather re-create it as we do with FlameChart. BUG=471600 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192811

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelinePanel.js	View		3 chunks	+3 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043953003/1

5 years, 8 months ago (2015-03-31 07:19:55 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 08:41:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192811

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages