Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1043953003: Timeline: do not cache TimelineView (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index 592cbb8ad66a7302ef7783a9aaf6b7bf321c3f36..a97872ffee70f2dffaea4245f701de6bd20f8b76 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -220,16 +220,6 @@ WebInspector.TimelinePanel.prototype = {
},
/**
- * @return {!WebInspector.TimelineView}
- */
- _timelineView: function()
- {
- if (!this._lazyTimelineView)
- this._lazyTimelineView = new WebInspector.TimelineView(this, this._model);
- return this._lazyTimelineView;
- },
-
- /**
* @return {!WebInspector.View}
*/
_layersView: function()
@@ -608,7 +598,9 @@ WebInspector.TimelinePanel.prototype = {
this._flameChart = null;
this._filterBar.filterButton().setEnabled(true);
this._filtersContainer.classList.toggle("hidden", !this._filterBar.filtersToggled());
- this._addModeView(this._timelineView());
+ var timelineView = new WebInspector.TimelineView(this, this._model)
+ this._addModeView(timelineView);
+ timelineView.setFrameModel(isFrameMode ? this._frameModel() : null);
}
if (this._captureMemorySetting.get()) {
@@ -618,9 +610,6 @@ WebInspector.TimelinePanel.prototype = {
}
var mainTarget = WebInspector.targetManager.mainTarget();
- if (this._lazyTimelineView)
- this._lazyTimelineView.setFrameModel(isFrameMode ? this._frameModel() : null);
-
this._overviewPane.setOverviewControls(this._overviewControls);
this.doResize();
this._selection = null;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698