Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 1043403003: Revert of Enable 'First-Party-Only' cookies by default. (Closed)

Created:
5 years, 8 months ago by Mike West
Modified:
5 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable 'First-Party-Only' cookies by default. (patchset #3 id:40001 of https://codereview.chromium.org/1032063002/) Reason for revert: Blink OWNERs would like to wait a bit before shipping: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wKZBCzcNssg/nZ1CFmgddJcJ Original issue's description: > Enable 'First-Party-Only' cookies by default. > > This patch reverts https://codereview.chromium.org/940373002, and adds > back in the ~2 lines and tests that are still relevant. > > BUG=459154 > > Committed: https://crrev.com/bdd0b09b5371066ad6d6c0ef2c32f5b92595316d > Cr-Commit-Position: refs/heads/master@{#322533} TBR=cbentzel@chromium.org,jochen@chromium.org,rsleevi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459154 Committed: https://crrev.com/0513c9d42fe0220d30174c55367e4a13b36f9cfd Cr-Commit-Position: refs/heads/master@{#323190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -2 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 5 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_network_delegate.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/base/network_delegate.h View 2 chunks +11 lines, -0 lines 0 comments Download
M net/base/network_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +8 lines, -1 line 0 comments Download
M net/url_request/url_request_test_util.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 4 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Created Revert of Enable 'First-Party-Only' cookies by default.
5 years, 8 months ago (2015-04-01 05:52:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1043403003/1
5 years, 8 months ago (2015-04-01 05:52:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 05:53:27 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 05:54:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0513c9d42fe0220d30174c55367e4a13b36f9cfd
Cr-Commit-Position: refs/heads/master@{#323190}

Powered by Google App Engine
This is Rietveld 408576698