Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 940373002: First-Party Cookies: Wire it up as an experimental web platform feature (Closed)

Created:
5 years, 10 months ago by Mike West
Modified:
5 years, 9 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@first-party
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

First-Party Cookies: Wire it up as an experimental web platform feature This patch adds a flag to the NetworkDelegate to control the first-party cookies experiment, and implements the flag in the ChromeNetworkDelegate and ShellNetworkDelegate by checking the value of the experimental web platform features command-line flag. Once we decide whether or not to ship this feature, we can revert everything in this patch other than the tests and the change to URLRequestHttpJob::DoLoadCookies. BUG=459154 Committed: https://crrev.com/3f3daac24caec2913641fe2fc2685feb738676ad Cr-Commit-Position: refs/heads/master@{#318295}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Feedback. #

Total comments: 2

Patch Set 4 : Rebase. #

Patch Set 5 : Nit. #

Patch Set 6 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -30 lines) Patch
chrome/browser/net/chrome_network_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Mike West
WDYT about this approach, Matt? I didn't add a flag to URLRequest, because the toggle ...
5 years, 10 months ago (2015-02-20 10:39:37 UTC) #2
mmenke
My review load is actually pretty light today, so far. https://codereview.chromium.org/940373002/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): https://codereview.chromium.org/940373002/diff/1/chrome/browser/net/chrome_network_delegate.cc#newcode299 ...
5 years, 10 months ago (2015-02-20 16:30:40 UTC) #3
Mike West
WDYT of these tests? https://codereview.chromium.org/940373002/diff/1/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): https://codereview.chromium.org/940373002/diff/1/chrome/browser/net/chrome_network_delegate.cc#newcode299 chrome/browser/net/chrome_network_delegate.cc:299: experimental_web_platform_features_enabled_(false), On 2015/02/20 at 16:30:39, ...
5 years, 10 months ago (2015-02-23 15:51:17 UTC) #4
Mike West
Friendly ping. :)
5 years, 10 months ago (2015-02-24 16:26:31 UTC) #5
mmenke
On 2015/02/24 16:26:31, Mike West wrote: > Friendly ping. :) Took a sick day yesterday, ...
5 years, 10 months ago (2015-02-24 16:30:35 UTC) #6
Mike West
On 2015/02/24 at 16:30:35, mmenke wrote: > On 2015/02/24 16:26:31, Mike West wrote: > > ...
5 years, 10 months ago (2015-02-24 16:54:12 UTC) #7
mmenke
LGTM, sorry for slowness! Still recovering. https://codereview.chromium.org/940373002/diff/40001/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): https://codereview.chromium.org/940373002/diff/40001/chrome/browser/net/chrome_network_delegate.cc#newcode306 chrome/browser/net/chrome_network_delegate.cc:306: switches::kEnableExperimentalWebPlatformFeatures); nit: Can ...
5 years, 10 months ago (2015-02-26 16:24:59 UTC) #8
Mike West
On 2015/02/26 16:24:59, mmenke wrote: > LGTM, sorry for slowness! Still recovering. No worries. Thanks ...
5 years, 10 months ago (2015-02-26 18:23:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940373002/80001
5 years, 10 months ago (2015-02-26 18:23:37 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-26 20:15:42 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 20:16:51 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3f3daac24caec2913641fe2fc2685feb738676ad
Cr-Commit-Position: refs/heads/master@{#318295}

Powered by Google App Engine
This is Rietveld 408576698