Source/modules/notifications/Notification.idl - Issue 1042513002: Add the vibrate attribute to the Notification object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.idl

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/Notification.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/NotificationOptions.idl » ('j') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.idl

diff --git a/Source/modules/notifications/Notification.idl b/Source/modules/notifications/Notification.idl

index e684d228a338e83e0478ab345aef6b15b0482777..32072f7a36108e4379852cdb388472a16165b0b5 100644

--- a/Source/modules/notifications/Notification.idl

+++ b/Source/modules/notifications/Notification.idl

@@ -55,6 +55,8 @@

readonly attribute DOMString body;

readonly attribute DOMString tag;

readonly attribute DOMString icon;

+ [RuntimeEnabled=NotificationExperimental] readonly attribute sequence<unsigned long>? vibrate;

timvolodine 2015/04/13 11:55:18 why is "sequence<unsigned long>" used here and "un

Sanghyun Park 2015/04/13 13:35:08 It has not been decided how to expose the vibratio

readonly attribute boolean silent;

[RuntimeEnabled=NotificationExperimental, CallWith=ScriptState] readonly attribute any data;