Source/modules/notifications/Notification.idl - Issue 1042513002: Add the vibrate attribute to the Notification object

Side by Side Diff: Source/modules/notifications/Notification.idl

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/notifications/Notification.cpp ('K') | « Source/modules/notifications/Notification.cpp ('k') | Source/modules/notifications/NotificationOptions.idl » ('j') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.	3 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 [MeasureAs=NotificationShowEvent] attribute EventHandler onshow;	48 [MeasureAs=NotificationShowEvent] attribute EventHandler onshow;

49 attribute EventHandler onerror;	49 attribute EventHandler onerror;

50 [MeasureAs=NotificationCloseEvent] attribute EventHandler onclose;	50 [MeasureAs=NotificationCloseEvent] attribute EventHandler onclose;

51	51

52 readonly attribute DOMString title;	52 readonly attribute DOMString title;

53 readonly attribute DOMString dir;	53 readonly attribute DOMString dir;

54 readonly attribute DOMString lang;	54 readonly attribute DOMString lang;

55 readonly attribute DOMString body;	55 readonly attribute DOMString body;

56 readonly attribute DOMString tag;	56 readonly attribute DOMString tag;

57 readonly attribute DOMString icon;	57 readonly attribute DOMString icon;

	58

	59 [RuntimeEnabled=NotificationExperimental] readonly attribute sequence<unsign ed long>? vibrate;
	timvolodine 2015/04/13 11:55:18 why is "sequence<unsigned long>" used here and "un why is "sequence<unsigned long>" used here and "unsigned long or sequence<unsigned long>" in NotificationOptions.idl? is this intentional? Sanghyun Park 2015/04/13 13:35:08 It has not been decided how to expose the vibratio Show quoted text On 2015/04/13 11:55:18, timvolodine wrote: > why is "sequence<unsigned long>" used here and "unsigned long or > sequence<unsigned long>" in NotificationOptions.idl? is this intentional? It has not been decided how to expose the vibration attribute back to the developer in spec[1]. I and Peter were decided to support only sequence type . If you want to know details, please refer the Peter's comment :) [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=23682. [2] https://codereview.chromium.org/1042513002/patch/240001/250007
58 readonly attribute boolean silent;	60 readonly attribute boolean silent;

59 [RuntimeEnabled=NotificationExperimental, CallWith=ScriptState] readonly att ribute any data;	61 [RuntimeEnabled=NotificationExperimental, CallWith=ScriptState] readonly att ribute any data;

60	62

61 [MeasureAs=NotificationClosed] void close();	63 [MeasureAs=NotificationClosed] void close();

62 };	64 };

OLD	NEW