Source/modules/notifications/NotificationOptions.idl - Issue 1042513002: Add the vibrate attribute to the Notification object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/NotificationOptions.idl

Issue 1042513002: Add the vibrate attribute to the Notification object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/notifications/Notification.idl ('K') | « Source/modules/notifications/Notification.idl ('k') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/NotificationOptions.idl

diff --git a/Source/modules/notifications/NotificationOptions.idl b/Source/modules/notifications/NotificationOptions.idl

index 716ce68f4ea9ae8c1bc3eadbb29dbcf4536f7859..a51fb0415d26bbe0b81c8ad92b92e26713142246 100644

--- a/Source/modules/notifications/NotificationOptions.idl

+++ b/Source/modules/notifications/NotificationOptions.idl

@@ -16,6 +16,8 @@ dictionary NotificationOptions {

DOMString body = "";

DOMString tag = "";

DOMString icon;

+ // TODO(sh919.park): vibrate should be ([Clamp] unsigned long or sequence<unsigned long>)

+ [RuntimeEnabled=NotificationExperimental] (unsigned long or sequence<unsigned long>) vibrate;

boolean silent = false;

[RuntimeEnabled=NotificationExperimental] any data = null;

};