Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1042373002: Emulate gamma fix by making glyphs thicker or thinner (Closed)

Created:
5 years, 8 months ago by jvanverth1
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Emulate distance field gamma fix by making glyphs thicker or thinner The idea here is that we determine the 0.5 crossover for each row in the gamma table, then invert the mapping to determine which point that maps to in the original range [-.65, .65]. That gives us a change in the apparent width of the glyph that closely corresponds to the change produced by the gamma fix. BUG=skia:2933 Committed: https://skia.googlesource.com/skia/+/21deace8efc8e167d8626187ef0e6b4c241324b6

Patch Set 1 #

Patch Set 2 : Fix release build #

Patch Set 3 : Fix release build #

Patch Set 4 : Rebase to ToT #

Total comments: 2

Patch Set 5 : Fix some compile issues #

Patch Set 6 : Remove header #

Total comments: 2

Patch Set 7 : Implement != by using == #

Patch Set 8 : Some clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -170 lines) Patch
M src/gpu/GrDistanceFieldTextContext.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 5 6 7 8 chunks +106 lines, -49 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 1 2 3 4 5 6 7 7 chunks +29 lines, -20 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 3 4 5 6 7 22 chunks +60 lines, -100 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
jvanverth1
5 years, 8 months ago (2015-03-31 18:58:22 UTC) #2
bungeman-skia
https://codereview.chromium.org/1042373002/diff/60001/src/gpu/effects/GrDistanceFieldTextureEffect.cpp File src/gpu/effects/GrDistanceFieldTextureEffect.cpp (right): https://codereview.chromium.org/1042373002/diff/60001/src/gpu/effects/GrDistanceFieldTextureEffect.cpp#newcode15 src/gpu/effects/GrDistanceFieldTextureEffect.cpp:15: #include "../utils/SkCamera.h" Seems like you can remove this?
5 years, 8 months ago (2015-04-01 15:38:56 UTC) #3
jvanverth1
https://codereview.chromium.org/1042373002/diff/60001/src/gpu/effects/GrDistanceFieldTextureEffect.cpp File src/gpu/effects/GrDistanceFieldTextureEffect.cpp (right): https://codereview.chromium.org/1042373002/diff/60001/src/gpu/effects/GrDistanceFieldTextureEffect.cpp#newcode15 src/gpu/effects/GrDistanceFieldTextureEffect.cpp:15: #include "../utils/SkCamera.h" On 2015/04/01 15:38:56, bungeman1 wrote: > Seems ...
5 years, 8 months ago (2015-04-01 15:42:13 UTC) #4
egdaniel
https://codereview.chromium.org/1042373002/diff/100001/src/gpu/effects/GrDistanceFieldTextureEffect.h File src/gpu/effects/GrDistanceFieldTextureEffect.h (right): https://codereview.chromium.org/1042373002/diff/100001/src/gpu/effects/GrDistanceFieldTextureEffect.h#newcode192 src/gpu/effects/GrDistanceFieldTextureEffect.h:192: bool operator!=(const WidthAdjust& wa) const { cleaner to do ...
5 years, 8 months ago (2015-04-01 15:55:13 UTC) #5
jvanverth1
https://codereview.chromium.org/1042373002/diff/100001/src/gpu/effects/GrDistanceFieldTextureEffect.h File src/gpu/effects/GrDistanceFieldTextureEffect.h (right): https://codereview.chromium.org/1042373002/diff/100001/src/gpu/effects/GrDistanceFieldTextureEffect.h#newcode192 src/gpu/effects/GrDistanceFieldTextureEffect.h:192: bool operator!=(const WidthAdjust& wa) const { On 2015/04/01 15:55:13, ...
5 years, 8 months ago (2015-04-01 16:21:01 UTC) #6
bungeman-skia
I'm mostly writing this as an explanation to myself... maybe this will help with a ...
5 years, 8 months ago (2015-04-01 17:38:23 UTC) #7
jvanverth1
Updated to include an edited version of bungeman's comments, plus some other clean up.
5 years, 8 months ago (2015-04-01 19:14:15 UTC) #8
bungeman-skia
It's all approximations. If it's good enough, lgtm, at least for the idea.
5 years, 8 months ago (2015-04-01 19:21:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042373002/140001
5 years, 8 months ago (2015-04-01 19:24:02 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 19:43:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/21deace8efc8e167d8626187ef0e6b4c241324b6

Powered by Google App Engine
This is Rietveld 408576698