Source/core/inspector/InspectorAnimationAgent.h - Issue 1042143005: Devtools Animations: Support multiple frames in the animation timeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorAnimationAgent.h

Issue 1042143005: Devtools Animations: Support multiple frames in the animation timeline (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector-protocol/resources/test-page-trigger-animation.html ('k') | Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | Source/core/inspector/InspectorAnimationAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorAnimationAgent.h

diff --git a/Source/core/inspector/InspectorAnimationAgent.h b/Source/core/inspector/InspectorAnimationAgent.h

index bdf7a15f33d789e2266fb6a8ac70f55e8fb913f7..987f2a66468df597c69fd5b75aae12c4b867edaa 100644

--- a/Source/core/inspector/InspectorAnimationAgent.h

+++ b/Source/core/inspector/InspectorAnimationAgent.h

@@ -36,8 +36,8 @@ public:

// Protocol method implementations

virtual void getAnimationPlayersForNode(ErrorString*, int nodeId, bool includeSubtreeAnimations, RefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationPlayer> >& animationPlayersArray) override;

virtual void getPlaybackRate(ErrorString*, double* playbackRate) override;

- virtual void setPlaybackRate(ErrorString*, double playbackRate) override;

- virtual void setCurrentTime(ErrorString*, double currentTime) override;

+ virtual void setPlaybackRate(ErrorString*, double playbackRate, RefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationStartTime>>& animationStartTimes) override;

+ virtual void setCurrentTime(ErrorString*, double normalisedCurrentTime, RefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationStartTime>>& animationStartTimes) override;

virtual void setTiming(ErrorString*, const String& playerId, double duration, double delay) override;

// API for InspectorInstrumentation

@@ -60,6 +60,7 @@ private:

PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&);

PassRefPtr<TypeBuilder::Animation::AnimationPlayer> buildObjectForAnimationPlayer(AnimationPlayer&, AnimationType, PassRefPtr<TypeBuilder::Animation::KeyframesRule> keyframeRule = nullptr);

PassRefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationPlayer> > buildArrayForAnimationPlayers(Element&, const WillBeHeapVector<RefPtrWillBeMember<AnimationPlayer> >);

+ PassRefPtr<TypeBuilder::Array<TypeBuilder::Animation::AnimationStartTime>> buildArrayForStartTimes();

RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;

RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;