Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1041743002: Serializer: move to a subfolder and clean up includes. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: move to a subfolder and clean up includes. R=jochen@chromium.org Committed: https://crrev.com/019096f82915b68a22807f683b878e42517a3cab Cr-Commit-Position: refs/heads/master@{#27501}

Patch Set 1 #

Patch Set 2 : fix build.gn #

Patch Set 3 : fix includes #

Patch Set 4 : removed OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4652 lines) Patch
M BUILD.gn View 1 5 chunks +11 lines, -11 lines 0 comments Download
M src/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/gdb-jit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/log.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
D src/mksnapshot.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D src/natives.h View 1 chunk +0 lines, -49 lines 0 comments Download
D src/natives-external.cc View 1 chunk +0 lines, -234 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/serialize.h View 1 chunk +0 lines, -980 lines 0 comments Download
D src/serialize.cc View 1 chunk +0 lines, -2542 lines 0 comments Download
D src/snapshot.h View 1 chunk +0 lines, -93 lines 0 comments Download
D src/snapshot-common.cc View 1 chunk +0 lines, -229 lines 0 comments Download
D src/snapshot-empty.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D src/snapshot-external.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D src/snapshot-source-sink.h View 1 chunk +0 lines, -107 lines 0 comments Download
D src/snapshot-source-sink.cc View 1 chunk +0 lines, -67 lines 0 comments Download
A src/snapshot/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + src/snapshot/mksnapshot.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/snapshot/natives.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/snapshot/natives-external.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + src/snapshot/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/snapshot/serialize.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/snapshot/snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/snapshot/snapshot-common.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/snapshot/snapshot-empty.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/snapshot/snapshot-external.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + src/snapshot/snapshot-source-sink.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/snapshot/snapshot-source-sink.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-date.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-javascript-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-js-arm64-variables.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-lockers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/external-reference-check.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 5 chunks +11 lines, -11 lines 0 comments Download
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 9 months ago (2015-03-27 14:25:59 UTC) #1
jochen (gone - plz use gerrit)
change looks good, but I think it would be prudent to first discuss the addition ...
5 years, 9 months ago (2015-03-27 14:38:03 UTC) #2
Yang
On 2015/03/27 14:38:03, jochen wrote: > change looks good, but I think it would be ...
5 years, 9 months ago (2015-03-27 14:40:01 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-27 15:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041743002/50001
5 years, 9 months ago (2015-03-27 15:26:38 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 9 months ago (2015-03-27 15:29:05 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 15:29:15 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/019096f82915b68a22807f683b878e42517a3cab
Cr-Commit-Position: refs/heads/master@{#27501}

Powered by Google App Engine
This is Rietveld 408576698