runtime/vm/dart_api_impl.h - Issue 1041523002: Refactor Thread lifecycle interface, add Thread::Enter/ExitIsolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.h

Issue 1041523002: Refactor Thread lifecycle interface, add Thread::Enter/ExitIsolate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.h

===================================================================

--- runtime/vm/dart_api_impl.h (revision 44762)

+++ runtime/vm/dart_api_impl.h (working copy)

@@ -291,7 +291,10 @@

: saved_isolate_(current_isolate) {

}

~IsolateSaver() {

- Isolate::SetCurrent(saved_isolate_);

+ // TODO(koda): Audit users; they should know whether they're in an isolate.

+ if (saved_isolate_ != NULL) {

+ Thread::EnterIsolate(saved_isolate_);

+ }

}

private:

Isolate* saved_isolate_;

« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »