runtime/vm/dart_api_impl.cc - Issue 1041523002: Refactor Thread lifecycle interface, add Thread::Enter/ExitIsolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1041523002: Refactor Thread lifecycle interface, add Thread::Enter/ExitIsolate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 44762)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -1356,7 +1356,10 @@

CHECK_NO_ISOLATE(Isolate::Current());

// TODO(16615): Validate isolate parameter.

Isolate* iso = reinterpret_cast<Isolate*>(isolate);

- Isolate::SetCurrent(iso);

+ if (iso->mutator_thread() != NULL) {

+ FATAL("Multiple mutators within one isolate is not supported.");

+ }

+ Thread::EnterIsolate(iso);

}

@@ -1384,7 +1387,7 @@

DART_EXPORT void Dart_ExitIsolate() {

CHECK_ISOLATE(Isolate::Current());

- Isolate::SetCurrent(NULL);

+ Thread::ExitIsolate();

}

« no previous file with comments | « runtime/vm/dart_api_impl.h ('k') | runtime/vm/gc_sweeper.cc » ('j') | no next file with comments »