runtime/vm/dart.cc - Issue 1041523002: Refactor Thread lifecycle interface, add Thread::Enter/ExitIsolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 1041523002: Refactor Thread lifecycle interface, add Thread::Enter/ExitIsolate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart.cc

===================================================================

--- runtime/vm/dart.cc (revision 44762)

+++ runtime/vm/dart.cc (working copy)

@@ -146,7 +146,7 @@

Dart_EnterScope();

Api::InitHandles();

- Isolate::SetCurrent(NULL); // Unregister the VM isolate from this thread.

+ Thread::ExitIsolate(); // Unregister the VM isolate from this thread.

Isolate::SetCreateCallback(create);

Isolate::SetInterruptCallback(interrupt);

Isolate::SetUnhandledExceptionCallback(unhandled);

@@ -175,7 +175,7 @@

thread_pool_ = NULL;

// Set the VM isolate as current isolate.

- Isolate::SetCurrent(vm_isolate_);

+ Thread::EnterIsolate(vm_isolate_);

// There is a planned and known asymmetry here: We exit one scope for the VM

// isolate to account for the scope that was entered in Dart_InitOnce.

« no previous file with comments | « runtime/vm/benchmark_test.cc ('k') | runtime/vm/dart_api_impl.h » ('j') | no next file with comments »