Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1041193002: Fixes clang warning in GLSurfaceOzone. (Closed)

Created:
5 years, 8 months ago by dnicoara
Modified:
5 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, ozone-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Fixes clang warning in GLSurfaceOzone. Introduced in https://codereview.chromium.org/938873002/ R=piman@chromium.org BUG=None Review URL: https://codereview.chromium.org/967343003 Cr-Commit-Position: refs/heads/master@{#318826} (cherry picked from commit 8d23afa1dee0d0eaa1ed0782963c3a6ac263ae97) Simplify FakeGpuProcess* video accelerator tests Make DispatchToGpuPlatformSupportTask and DispatchToGpuPlatformSupportHostTask statics, removing the weak ptrs (and failing DCHECKS in that code) altogether. BUG=447798 Review URL: https://codereview.chromium.org/1017673003 Cr-Commit-Position: refs/heads/master@{#321212} (cherry picked from commit 72b1eacd439fcb0bcf45ae7de2d8a9f578804ac6) Fix at_exit error in video_decode tests ui::OzoneGpuTestHelper needs to be uninstantiated in TearDown() since it creates a base::Thread which wants to register with the AtExitManager. However the AtExitManager runs out of scope before the testing::Environment. BUG=447798 TEST=compile and run ./video_decode_accelerator_unittest (I had https://codereview.chromium.org/938873002/ applied as well to make sure tests succeed) Review URL: https://codereview.chromium.org/949183004 Cr-Commit-Position: refs/heads/master@{#319148} (cherry picked from commit c7a207e106d84ac81344a7c7cef8394ed672f0a3) Add a new API to create a surfaceless GLSurface for Ozone Reverting CreateViewGLSurface to creating a surface that works as expected Chrome uses the new surfaceless API, all others use the old one BUG=447798 Review URL: https://codereview.chromium.org/938873002 Cr-Commit-Position: refs/heads/master@{#318786} (cherry picked from commit e86e411c3038fd5be67438da29f0ff17828f226f) ozone: dri: add synchronous SwapBuffers support on surfaceless BUG=447798 TEST=ozone_unittests Review URL: https://codereview.chromium.org/960273003 Cr-Commit-Position: refs/heads/master@{#318457} (cherry picked from commit 210577c2e1b7bb0462ccbb7905c800568ba3888e) Committed: https://chromium.googlesource.com/chromium/src/+/52dbe19e37811d992a10ac36f8f2419f837d2549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -84 lines) Patch
M content/common/gpu/image_transport_surface_linux.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 6 chunks +17 lines, -4 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 5 chunks +179 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.cc View 6 chunks +36 lines, -11 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surfaceless.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller_unittest.cc View 9 chunks +20 lines, -20 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane_manager_legacy.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_plane_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_dri_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_dri_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/public/ozone_gpu_test_helper.cc View 3 chunks +17 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dnicoara
5 years, 8 months ago (2015-03-30 15:45:36 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52dbe19e37811d992a10ac36f8f2419f837d2549.

Powered by Google App Engine
This is Rietveld 408576698