Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 949183004: Fix at_exit error in video_decode tests (Closed)

Created:
5 years, 10 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix at_exit error in video_decode tests ui::OzoneGpuTestHelper needs to be uninstantiated in TearDown() since it creates a base::Thread which wants to register with the AtExitManager. However the AtExitManager runs out of scope before the testing::Environment. BUG=447798 TEST=compile and run ./video_decode_accelerator_unittest (I had https://codereview.chromium.org/938873002/ applied as well to make sure tests succeed) Committed: https://crrev.com/c7a207e106d84ac81344a7c7cef8394ed672f0a3 Cr-Commit-Position: refs/heads/master@{#319148}

Patch Set 1 #

Patch Set 2 : if def #

Patch Set 3 : rebased #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
dnicoara
Please take a look. Sorry for the OzoneGpuTestHelper omission.
5 years, 10 months ago (2015-02-24 17:44:15 UTC) #2
dnicoara
Gentle ping.
5 years, 9 months ago (2015-03-03 15:37:56 UTC) #3
Pawel Osciak
Sorry missed this. lgtm.
5 years, 9 months ago (2015-03-04 01:16:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949183004/40001
5 years, 9 months ago (2015-03-04 02:11:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/16158)
5 years, 9 months ago (2015-03-04 05:13:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949183004/40001
5 years, 9 months ago (2015-03-04 13:41:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/16320)
5 years, 9 months ago (2015-03-04 16:51:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949183004/40001
5 years, 9 months ago (2015-03-04 16:54:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/16376)
5 years, 9 months ago (2015-03-04 20:00:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949183004/60001
5 years, 9 months ago (2015-03-04 22:42:14 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-04 22:47:40 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:48:22 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c7a207e106d84ac81344a7c7cef8394ed672f0a3
Cr-Commit-Position: refs/heads/master@{#319148}

Powered by Google App Engine
This is Rietveld 408576698