Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 967343003: Fixes clang warning in GLSurfaceOzone. (Closed)

Created:
5 years, 9 months ago by gunsch
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, achaulk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes clang warning in GLSurfaceOzone. Introduced in https://codereview.chromium.org/938873002/ R=piman@chromium.org BUG=None Committed: https://crrev.com/8d23afa1dee0d0eaa1ed0782963c3a6ac263ae97 Cr-Commit-Position: refs/heads/master@{#318826}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit: remove semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/gl/gl_surface_ozone.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
gunsch
5 years, 9 months ago (2015-03-03 00:30:40 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-03 00:35:39 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/967343003/diff/1/ui/gl/gl_surface_ozone.cc File ui/gl/gl_surface_ozone.cc (right): https://codereview.chromium.org/967343003/diff/1/ui/gl/gl_surface_ozone.cc#newcode308 ui/gl/gl_surface_ozone.cc:308: ~SurfaceImage() override {}; nit: remove ;
5 years, 9 months ago (2015-03-03 00:36:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967343003/1
5 years, 9 months ago (2015-03-03 00:36:13 UTC) #7
gunsch
https://codereview.chromium.org/967343003/diff/1/ui/gl/gl_surface_ozone.cc File ui/gl/gl_surface_ozone.cc (right): https://codereview.chromium.org/967343003/diff/1/ui/gl/gl_surface_ozone.cc#newcode308 ui/gl/gl_surface_ozone.cc:308: ~SurfaceImage() override {}; On 2015/03/03 00:36:00, Dan Beam wrote: ...
5 years, 9 months ago (2015-03-03 00:38:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967343003/20001
5 years, 9 months ago (2015-03-03 00:38:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 03:16:07 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 03:16:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d23afa1dee0d0eaa1ed0782963c3a6ac263ae97
Cr-Commit-Position: refs/heads/master@{#318826}

Powered by Google App Engine
This is Rietveld 408576698