Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1041043008: Catch utility process StartBatchMode failures (Closed)

Created:
5 years, 8 months ago by Theresa
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch utility process StartBatchMode failures BUG=472180 Committed: https://crrev.com/612b9b6a87e75b87658eebf6a64474cca6395515 Cr-Commit-Position: refs/heads/master@{#323154}

Patch Set 1 #

Patch Set 2 : Update comments in header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/image_decoder.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/image_decoder.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Theresa
ptal - this is a dev release blocker, hoping to land by eod tomorrow
5 years, 8 months ago (2015-03-31 22:38:47 UTC) #2
Lei Zhang
lgtm Can you update the header to describe the modified behavior for DecodeImageInSandbox() and StartBatchMode() ...
5 years, 8 months ago (2015-03-31 23:08:51 UTC) #3
Theresa
On 2015/03/31 23:08:51, Lei Zhang wrote: > lgtm > > Can you update the header ...
5 years, 8 months ago (2015-03-31 23:18:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1041043008/20001
5 years, 8 months ago (2015-03-31 23:22:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 00:33:35 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 00:34:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/612b9b6a87e75b87658eebf6a64474cca6395515
Cr-Commit-Position: refs/heads/master@{#323154}

Powered by Google App Engine
This is Rietveld 408576698