Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6533)

Unified Diff: chrome/browser/image_decoder.h

Issue 1041043008: Catch utility process StartBatchMode failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments in header Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/image_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/image_decoder.h
diff --git a/chrome/browser/image_decoder.h b/chrome/browser/image_decoder.h
index d4615cff82d437137f86b53da416defe804eb55f..438622c442d48a9b2bc5b125b11a8d299faccbd1 100644
--- a/chrome/browser/image_decoder.h
+++ b/chrome/browser/image_decoder.h
@@ -85,7 +85,8 @@ class ImageDecoder : public content::UtilityProcessHostClient {
~ImageDecoder() override;
// Sends a request to the sandboxed process to decode the image. Starts
- // batch mode if necessary.
+ // batch mode if necessary. If the utility process fails to start,
+ // an OnDecodeImageFailed task is posted to image_request's |task_runner_|.
void DecodeImageInSandbox(ImageRequest* image_request,
const std::vector<unsigned char>& image_data,
ImageCodec image_codec,
@@ -96,6 +97,8 @@ class ImageDecoder : public content::UtilityProcessHostClient {
using RequestMap = std::map<int, ImageRequest*>;
// Starts UtilityProcessHost in batch mode and starts |batch_mode_timer_|.
+ // If the utility process fails to start, the method resets
+ // |utility_process_host_| and returns.
void StartBatchMode();
// Stops batch mode if no requests have come in since
« no previous file with comments | « no previous file | chrome/browser/image_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698