Catch utility process StartBatchMode failures

chrome/browser/image_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/image_decoder.h"
 
 #include "base/bind.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_utility_messages.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 62 matching lines @@
 
 void ImageDecoder::DecodeImageInSandbox(
     ImageRequest* image_request,
     const std::vector<unsigned char>& image_data,
     ImageCodec image_codec,
     bool shrink_to_fit) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (!utility_process_host_) {
     StartBatchMode();
   }
+  if (!utility_process_host_) {
+    // Utility process failed to start; notify delegate and return.
+    // Without this check, we were seeing crashes on startup. Further
+    // investigation is needed to determine why the utility process
+    // is failing to start. See crbug.com/472272
+    image_request->task_runner()->PostTask(
+        FROM_HERE, base::Bind(&ImageRequest::OnDecodeImageFailed,
+                              base::Unretained(image_request)));
+    return;
+  }
 
   last_request_ = base::TimeTicks::Now();
   base::AutoLock lock(map_lock_);
   image_request_id_map_.insert(
       std::make_pair(image_request_id_counter_, image_request));
 
   switch (image_codec) {
     case ROBUST_JPEG_CODEC:
       utility_process_host_->Send(new ChromeUtilityMsg_RobustJPEGDecodeImage(
           image_data, image_request_id_counter_));
@@ skipping 17 matching lines @@
       ++it;
     }
   }
 }
 
 void ImageDecoder::StartBatchMode() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   utility_process_host_ =
       UtilityProcessHost::Create(this, base::MessageLoopProxy::current().get())
           ->AsWeakPtr();
-  utility_process_host_->StartBatchMode();
+  if (!utility_process_host_->StartBatchMode()) {
+     utility_process_host_.reset();
+     return;
+  }
   batch_mode_timer_.Start(
       FROM_HERE, base::TimeDelta::FromSeconds(kBatchModeTimeoutSeconds),
       this, &ImageDecoder::StopBatchMode);
 }
 
 void ImageDecoder::StopBatchMode() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if ((base::TimeTicks::Now() - last_request_)
       < base::TimeDelta::FromSeconds(kBatchModeTimeoutSeconds)) {
     return;
@@ skipping 41 matching lines @@
   auto it = image_request_id_map_.find(request_id);
   if (it != image_request_id_map_.end()) {
     ImageRequest* image_request = it->second;
     image_request->task_runner()->PostTask(
         FROM_HERE, base::Bind(&ImageRequest::OnDecodeImageFailed,
                               base::Unretained(image_request)));
 
     image_request_id_map_.erase(it);
   }
 }