Issue 103913012: Tweaks in how to apply bitmap filter levels in GPU.

Issue 103913012: Tweaks in how to apply bitmap filter levels in GPU. (Closed)

Created:
7 years ago by bsalomon

Modified:
7 years ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Tweaks in how to apply bitmap filter levels in GPU. Fix fallback to MIP from bicubic for bitmap shaders Skip MIP level generation on GPU when not minifying Add medium quality and mixed up/down matrix test cases to filterbitmap tests Committed: http://code.google.com/p/skia/source/detail?r=12697

Patch Set 1 #

Patch Set 2 : improve comment: #

Patch Set 3 : upload again, rietveld diff failed. #

Patch Set 4 : upload again, rietveld diff failed. #

Patch Set 5 : upload again, rietveld diff failed. #

Patch Set 6 : upload again, rietveld diff failed. #

Patch Set 7 : upload again, rietveld diff failed. #

Patch Set 8 : upload again, rietveld diff failed. #

Total comments: 3

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -36 lines)			Patch
M	gm/filterbitmap.cpp	View		8 chunks	+22 lines, -16 lines	0 comments	Download
M	src/core/SkBitmapProcShader.cpp	View	1	2 chunks	+31 lines, -15 lines	3 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 question (which I don't think we should act on right now) https://codereview.chromium.org/103913012/diff/130001/src/core/SkBitmapProcShader.cpp ...

7 years ago (2013-12-16 20:41:12 UTC) #2

bsalomon

https://codereview.chromium.org/103913012/diff/130001/src/core/SkBitmapProcShader.cpp File src/core/SkBitmapProcShader.cpp (right): https://codereview.chromium.org/103913012/diff/130001/src/core/SkBitmapProcShader.cpp#newcode397 src/core/SkBitmapProcShader.cpp:397: if (get_combined_min_stretch(context->getMatrix(), this->getLocalMatrix()) < On 2013/12/16 20:41:12, robertphillips wrote: ...

7 years ago (2013-12-16 20:47:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/103913012/130001

7 years ago (2013-12-16 20:53:49 UTC) #4

reed1

7 years ago (2013-12-16 21:31:52 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/103913012/diff/130001/src/core/SkBitmapProcSh...
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/103913012/diff/130001/src/core/SkBitmapProcSh...
src/core/SkBitmapProcShader.cpp:360: return viewMatrix.getMinStretch();
since we detect identity inside setConcat (for both args), can we live w/o
having to check it here too? Just to simplify the code.

Expand Messages | Collapse Messages