Use fallback URL more extensively

Use fallback URL more extensively

Currently, if you type a URL in the omnibox, and if the URL gets redirected
to a 'intent://' URL, then it does not launch a native app and it just gets
ignored.

I believe that this is for security / UI reasons (see crbug.com/331571),
but it is somewhat weird that your URL (e.g. http://goo.gl/ABCDE) gets
completely ignored, especially when you aren't sure whether goo.gl will be
redirected to a normal URL or to an intent URL.

This behavior can be improved for the case when fallback URL is used,
as we can load the fallback URL instead of ignoring the URL.

Also there are other cases fallback URL can be useful, such as when
Context#startActivityIfNeeded() returns false.

BUG=470722
Committed: https://crrev.com/9a23240a46096e9042b1499dad67ab1f947c9d17
Cr-Commit-Position: refs/heads/master@{#323162}

[Changwan Ryu, 2015-03-26 23:52:13]

changwan@chromium.org changed reviewers:
+ jaekyun@chromium.org, mariakhomenko@chromium.org

[Maria, 2015-03-27 00:12:59]

lgtm

https://codereview.chromium.org/1039013002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1039013002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:346:
*intent.)
indent 8 on second line and don't need parenthesis around the return description

[Changwan Ryu, 2015-03-27 02:09:50]

changwan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Changwan Ryu, 2015-03-27 02:09:51]

Changed implementation per Jaekyun's comment. Maria / Ted, do you see any
potential problem with this change?

https://codereview.chromium.org/1039013002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1039013002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:346:
*intent.)
On 2015/03/27 00:12:59, Maria wrote:
> indent 8 on second line and don't need parenthesis around the return
description

Done.

[Maria, 2015-03-27 05:14:47]

On 2015/03/27 02:09:51, Changwan Ryu wrote:
> Changed implementation per Jaekyun's comment. Maria / Ted, do you see any
> potential problem with this change?
> 
>
https://codereview.chromium.org/1039013002/diff/60001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
> (right):
> 
>
https://codereview.chromium.org/1039013002/diff/60001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:346:
> *intent.)
> On 2015/03/27 00:12:59, Maria wrote:
> > indent 8 on second line and don't need parenthesis around the return
> description
> 
> Done.

I don't see a problem with the new version of the change.

[Maria, 2015-03-27 05:15:07]

lgtm

[Jaekyun Seok (inactive), 2015-03-27 05:27:47]

On 2015/03/27 05:15:07, Maria wrote:
> lgtm

I have a little concern to use a fallback URL for forward/backward/reload
navigation because it seems that a user could't go backward because of this.

I've already chatted with Changwan about this.

[Jaekyun Seok (inactive), 2015-03-27 05:53:18]

On 2015/03/27 05:27:47, Jaekyun Seok wrote:
> On 2015/03/27 05:15:07, Maria wrote:
> > lgtm
> 
> I have a little concern to use a fallback URL for forward/backward/reload
> navigation because it seems that a user could't go backward because of this.
> 
> I've already chatted with Changwan about this.

LGTM. My concern wouldn't block this CL because re-forwarding when backward
navigation is requested could happen even with a normal URL.

[Maria, 2015-03-27 05:54:00]

On 2015/03/27 05:27:47, Jaekyun Seok wrote:
> On 2015/03/27 05:15:07, Maria wrote:
> > lgtm
> 
> I have a little concern to use a fallback URL for forward/backward/reload
> navigation because it seems that a user could't go backward because of this.
> 
> I've already chatted with Changwan about this.

I believe the forward/backward/reload experience in this case will match what
happens on a regular redirect page. Granted, that's not the best experience
today...

[Ted C, 2015-03-28 01:34:44]

lgtm

https://codereview.chromium.org/1039013002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1039013002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:100:
// For instance, if this is a chained fallback URL, we ignore it.
should be indented 8 from the && above

[Changwan Ryu, 2015-04-01 00:13:00]

https://codereview.chromium.org/1039013002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1039013002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:100:
// For instance, if this is a chained fallback URL, we ignore it.
On 2015/03/28 01:34:44, Ted C wrote:
> should be indented 8 from the && above

Done.

[Changwan Ryu, 2015-04-01 00:55:07]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-04-01 00:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, jaekyun@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/1039013002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-04-01 00:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1039013002/140001

[commit-bot: I haz the power, 2015-04-01 01:19:59]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-04-01 01:21:21]

Patchset 8 (id:??) landed as
https://crrev.com/9a23240a46096e9042b1499dad67ab1f947c9d17
Cr-Commit-Position: refs/heads/master@{#323162}