Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4078)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 1039013002: Use fallback URL more extensively (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index bb2087db3219be74ce37060216778c6c55cd6793..f48162aa86c77fc8e01d7f9fbe88369f7f3d71a5 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -603,6 +603,30 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
}
@SmallTest
+ public void testFallback_UseFallbackUrlForRedirectionFromTypedInUrl() {
+ TabRedirectHandler redirectHandler = new TabRedirectHandler(null);
+
+ redirectHandler.updateNewUrlLoading(PageTransition.TYPED, false, 0, 0);
+ check("http://goo.gl/abcdefg", null, /* referrer */
+ false, /* incognito */
+ PageTransition.TYPED, NO_REDIRECT, true, false, redirectHandler,
+ OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
+
+ redirectHandler.updateNewUrlLoading(PageTransition.TYPED, true, 0, 0);
+ check(INTENT_URL_WITH_FALLBACK_URL_WITHOUT_PACKAGE_NAME, null, /* referrer */
+ false, /* incognito */
+ PageTransition.TYPED, REDIRECT, true, false, redirectHandler,
+ OverrideUrlLoadingResult.OVERRIDE_WITH_CLOBBERING_TAB, IGNORE);
+
+ // Now the user opens a link.
+ redirectHandler.updateNewUrlLoading(PageTransition.LINK, false, 0, 1);
+ check("http://m.youtube.com/", null, /* referrer */
+ false, /* incognito */
+ PageTransition.LINK, NO_REDIRECT, true, false, redirectHandler,
+ OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
+ }
+
+ @SmallTest
public void testIgnoreEffectiveRedirectFromIntentFallbackUrl() {
// We cannot resolve any intent, so fall-back URL will be used.
mDelegate.setCanResolveActivity(false);

Powered by Google App Engine
This is Rietveld 408576698