Use fallback URL more extensively

chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.externalnav;
 
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.content.ActivityNotFoundException;
 import android.content.ComponentName;
@@ skipping 55 matching lines @@
     public ExternalNavigationHandler(ExternalNavigationDelegate delegate) {
         mDelegate = delegate;
     }
 
     /**
      * Determines whether the URL needs to be sent as an intent to the system,
      * and sends it, if appropriate.
      * @return Whether the URL generated an intent, caused a navigation in
      *         current tab, or wasn't handled at all.
      */
+    public OverrideUrlLoadingResult shouldOverrideUrlLoading(ExternalNavigationParams params) {
+        Intent intent;
+        // Perform generic parsing of the URI to turn it into an Intent.
+        try {
+            intent = Intent.parseUri(params.getUrl(), Intent.URI_INTENT_SCHEME);
+        } catch (URISyntaxException ex) {
+            Log.w(TAG, "Bad URI " + params.getUrl() + ": " + ex.getMessage());
+            return OverrideUrlLoadingResult.NO_OVERRIDE;
+        }
+
+        boolean hasBrowserFallbackUrl = false;
+        String browserFallbackUrl = intent.getStringExtra(EXTRA_BROWSER_FALLBACK_URL);
+        if (browserFallbackUrl != null
+                && UrlUtilities.isValidForIntentFallbackNavigation(browserFallbackUrl)) {
+            hasBrowserFallbackUrl = true;
+        } else {
+            browserFallbackUrl = null;
+        }
+
+        OverrideUrlLoadingResult result = shouldOverrideUrlLoadingInternal(
+                params, intent, hasBrowserFallbackUrl, browserFallbackUrl);
+
+        if (result == OverrideUrlLoadingResult.NO_OVERRIDE && hasBrowserFallbackUrl
+                && (params.getRedirectHandler() == null
+                           // For instance, if this is a chained fallback URL, we ignore it.

[Ted C, 2015/03/28 01:34:44]

should be indented 8 from the && above

[Changwan Ryu, 2015/04/01 00:13:00]

Done.

+                           || !params.getRedirectHandler().shouldNotOverrideUrlLoading())) {
+            return clobberCurrentTabWithFallbackUrl(browserFallbackUrl, params);
+        }
+        return result;
+    }
+
     @TargetApi(Build.VERSION_CODES.ICE_CREAM_SANDWICH_MR1)
-    public OverrideUrlLoadingResult shouldOverrideUrlLoading(ExternalNavigationParams params) {
+    private OverrideUrlLoadingResult shouldOverrideUrlLoadingInternal(
+            ExternalNavigationParams params, Intent intent, boolean hasBrowserFallbackUrl,
+            String browserFallbackUrl) {
         // http://crbug.com/441284 : Disallow firing external intent while Chrome is in the
         // background.
         if (params.isApplicationMustBeInForeground() && !mDelegate.isChromeAppInForeground()) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
         // http://crbug.com/464669 : Disallow firing external intent from background tab.
         if (params.isBackgroundTabNavigation()) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
 
@@ skipping 15 matching lines @@
         //   This should be covered by not showing the picker if the core type is reload.
 
         // http://crbug.com/164194 . A navigation forwards or backwards should never trigger
         // the intent picker.
         if (isForwardBackNavigation) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
 
         // http://crbug/331571 : Do not override a navigation started from user typing.
         // http://crbug/424029 : Need to stay in Chrome for an intent heading explicitly to Chrome.
-        if (params.getRedirectHandler() != null
-                && params.getRedirectHandler().shouldStayInChrome()) {
-            return OverrideUrlLoadingResult.NO_OVERRIDE;
+        if (params.getRedirectHandler() != null) {
+            if (params.getRedirectHandler().shouldStayInChrome()
+                    || params.getRedirectHandler().shouldNotOverrideUrlLoading()) {
+                return OverrideUrlLoadingResult.NO_OVERRIDE;
+            }
         }
 
         // http://crbug.com/149218: We want to show the intent picker for ordinary links, providing
         // the link is not an incoming intent from another application, unless it's a redirect (see
         // below).
         boolean linkNotFromIntent = isLink && !isFromIntent;
 
         boolean isOnEffectiveIntentRedirect = params.getRedirectHandler() == null ? false
                 : params.getRedirectHandler().isOnEffectiveIntentRedirectChain();
 
@@ skipping 15 matching lines @@
         // page, there is clear intent to complete the navigation in Chrome.
         if (params.getReferrerUrl() != null && params.getReferrerUrl().startsWith(
                 UrlConstants.CHROME_SCHEME) && (params.getUrl().startsWith(UrlConstants.HTTP_SCHEME)
                         || params.getUrl().startsWith(UrlConstants.HTTPS_SCHEME))) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
 
         if (params.getUrl().startsWith(SCHEME_WTAI_MC)) {
             // wtai://wp/mc;number
             // number=string(phone-number)
-            Intent intent = new Intent(Intent.ACTION_VIEW,
+            mDelegate.startActivity(new Intent(Intent.ACTION_VIEW,
                     Uri.parse(WebView.SCHEME_TEL
-                            + params.getUrl().substring(SCHEME_WTAI_MC.length())));
-            mDelegate.startActivity(intent);
+                            + params.getUrl().substring(SCHEME_WTAI_MC.length()))));
             return OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT;
         } else if (params.getUrl().startsWith(SCHEME_WTAI)) {
             // TODO: handle other WTAI schemes.
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
 
         // The "about:" schemes are internal to the browser; don't want these to
         // be dispatched to other apps.
         if (params.getUrl().startsWith("about:")) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
@@ skipping 11 matching lines @@
         if (params.getUrl().matches(".*youtube\\.com.*[?&]pairingCode=.*")) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
 
         // TODO(changwan): check if we need to handle URL even when external intent is off.
         if (CommandLine.getInstance().hasSwitch(
                 ChromeSwitches.DISABLE_EXTERNAL_INTENT_REQUESTS)) {
             return OverrideUrlLoadingResult.NO_OVERRIDE;
         }
 
-        Intent intent;
-        // perform generic parsing of the URI to turn it into an Intent.
-        try {
-            intent = Intent.parseUri(params.getUrl(), Intent.URI_INTENT_SCHEME);
-        } catch (URISyntaxException ex) {
-            Log.w(TAG, "Bad URI " + params.getUrl() + ": " + ex.getMessage());
-            return OverrideUrlLoadingResult.NO_OVERRIDE;
-        }
-
-        boolean hasBrowserFallbackUrl = false;
-        String browserFallbackUrl = intent.getStringExtra(EXTRA_BROWSER_FALLBACK_URL);
-        if (browserFallbackUrl != null
-                && UrlUtilities.isValidForIntentFallbackNavigation(browserFallbackUrl)) {
-            hasBrowserFallbackUrl = true;
-        }
-
         // check whether the intent can be resolved. If not, we will see
         // whether we can download it from the Market.
         if (!mDelegate.canResolveActivity(intent)) {
             if (hasBrowserFallbackUrl) {
-                // NOTE: any further redirection from fall-back URL should not override URL loading.
-                // Otherwise, it can be used in chain for fingerprinting multiple app installation
-                // status in one shot. In order to prevent this scenario, we notify redirection
-                // handler that redirection from the current navigation should stay in Chrome.
-                if (params.getRedirectHandler() != null) {
-                    params.getRedirectHandler()
-                            .setShouldStayInChromeUntilNewUrlLoading();
-                }
-                return mDelegate.clobberCurrentTab(browserFallbackUrl, params.getReferrerUrl(),
-                        params.getTab());
+                return clobberCurrentTabWithFallbackUrl(browserFallbackUrl, params);
             }
             String packagename = intent.getPackage();
             if (packagename != null) {
                 try {
                     intent = new Intent(Intent.ACTION_VIEW, Uri.parse(
                             "market://details?id=" + packagename
                             + "&referrer=" + mDelegate.getPackageName()));
                     intent.addCategory(Intent.CATEGORY_BROWSABLE);
                     intent.setPackage("com.android.vending");
                     mDelegate.startActivity(intent);
@@ skipping 106 matching lines @@
             }
         } catch (ActivityNotFoundException ex) {
             // Ignore the error. If no application can handle the URL,
             // assume the browser can handle it.
         }
 
         return OverrideUrlLoadingResult.NO_OVERRIDE;
     }
 
     /**
+     * Clobber the current tab with fallback URL.
+     *
+     * @param browserFallbackUrl The fallback URL.
+     * @param params The external navigation params.
+     * @return {@link OverrideUrlLoadingResult} if the tab was clobbered, or we launched an
+     *         intent.
+     */
+    private OverrideUrlLoadingResult clobberCurrentTabWithFallbackUrl(
+            String browserFallbackUrl, ExternalNavigationParams params) {
+        // NOTE: any further redirection from fall-back URL should not override URL loading.
+        // Otherwise, it can be used in chain for fingerprinting multiple app installation
+        // status in one shot. In order to prevent this scenario, we notify redirection
+        // handler that redirection from the current navigation should stay in Chrome.
+        if (params.getRedirectHandler() != null) {
+            params.getRedirectHandler().setShouldNotOverrideUrlLoadingUntilNewUrlLoading();
+        }
+        return mDelegate.clobberCurrentTab(
+                browserFallbackUrl, params.getReferrerUrl(), params.getTab());
+    }
+
+    /**
      * @return Whether the |url| could be handled by an external application on the system.
      */
     public boolean canExternalAppHandleUrl(String url) {
         if (url.startsWith(SCHEME_WTAI_MC)) return true;
         try {
             Intent intent = Intent.parseUri(url, Intent.URI_INTENT_SCHEME);
             return intent.getPackage() != null || mDelegate.canResolveActivity(intent);
         } catch (URISyntaxException ex) {
             // Ignore the error.
         }
         return false;
     }
 }