Issue 1038843002: Get rid of SVGTextMetrics functions without an explicit TextDirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1038843002: Get rid of SVGTextMetrics functions without an explicit TextDirection (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
Erik Dahlström (inactive)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Get rid of SVGTextMetrics functions without an explicit TextDirection It's better to not use these at all. Open-code them at their current callsites with an intent of fixing the direction they specify. No functional changes. BUG=470326 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192605

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -22 lines)			Patch
M	Source/core/layout/svg/SVGTextMetrics.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/layout/svg/SVGTextMetrics.cpp	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	Source/core/layout/svg/SVGTextMetricsBuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/layout/svg/SVGTextQuery.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038843002/1

5 years, 9 months ago (2015-03-26 12:47:36 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-26 13:58:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192605

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages