Source/core/layout/svg/SVGTextMetricsBuilder.cpp - Issue 1038843002: Get rid of SVGTextMetrics functions without an explicit TextDirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/SVGTextMetricsBuilder.cpp

Issue 1038843002: Get rid of SVGTextMetrics functions without an explicit TextDirection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/svg/SVGTextMetricsBuilder.cpp

diff --git a/Source/core/layout/svg/SVGTextMetricsBuilder.cpp b/Source/core/layout/svg/SVGTextMetricsBuilder.cpp

index 7a8814b82c1aabe5072e3e43e27482ac3916a2bc..beba0d1f5811a142784ba19bd1f085b1b26d6e3b 100644

--- a/Source/core/layout/svg/SVGTextMetricsBuilder.cpp

+++ b/Source/core/layout/svg/SVGTextMetricsBuilder.cpp

@@ -74,7 +74,7 @@ private:

SVGTextMetricsCalculator::SVGTextMetricsCalculator(LayoutSVGInlineText* text)

: m_text(text)

, m_bidiRun(0)

- , m_run(SVGTextMetrics::constructTextRun(text, 0, text->textLength()))

+ , m_run(SVGTextMetrics::constructTextRun(text, 0, text->textLength(), text->styleRef().direction()))

, m_isComplexText(false)

, m_totalWidth(0)

{

« no previous file with comments | « Source/core/layout/svg/SVGTextMetrics.cpp ('k') | Source/core/layout/svg/SVGTextQuery.cpp » ('j') | no next file with comments »