Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: Source/core/layout/svg/SVGTextMetrics.cpp

Issue 1038843002: Get rid of SVGTextMetrics functions without an explicit TextDirection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/svg/SVGTextMetrics.h ('k') | Source/core/layout/svg/SVGTextMetricsBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/svg/SVGTextMetrics.cpp
diff --git a/Source/core/layout/svg/SVGTextMetrics.cpp b/Source/core/layout/svg/SVGTextMetrics.cpp
index 6cdced0fe67c4b1d5f5a6d5bf917e403985c0cbb..68beeb2e8370aca7b47265d0f26d547f6ead88c8 100644
--- a/Source/core/layout/svg/SVGTextMetrics.cpp
+++ b/Source/core/layout/svg/SVGTextMetrics.cpp
@@ -56,12 +56,6 @@ SVGTextMetrics::SVGTextMetrics(LayoutSVGInlineText* textRenderer, const TextRun&
m_length = static_cast<unsigned>(run.length());
}
-TextRun SVGTextMetrics::constructTextRun(LayoutSVGInlineText* text, unsigned position, unsigned length)
-{
- ASSERT(text->style());
- return constructTextRun(text, position, length, text->style()->direction());
-}
-
TextRun SVGTextMetrics::constructTextRun(LayoutSVGInlineText* text, unsigned position, unsigned length, TextDirection textDirection)
{
const LayoutStyle& style = text->styleRef();
@@ -96,12 +90,6 @@ SVGTextMetrics SVGTextMetrics::measureCharacterRange(LayoutSVGInlineText* text,
return SVGTextMetrics(text, constructTextRun(text, position, length, textDirection));
}
-SVGTextMetrics SVGTextMetrics::measureCharacterRange(LayoutSVGInlineText* text, unsigned position, unsigned length)
-{
- ASSERT(text);
- return SVGTextMetrics(text, constructTextRun(text, position, length));
-}
-
SVGTextMetrics::SVGTextMetrics(LayoutSVGInlineText* text, unsigned position, unsigned length, float width)
{
ASSERT(text);
« no previous file with comments | « Source/core/layout/svg/SVGTextMetrics.h ('k') | Source/core/layout/svg/SVGTextMetricsBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698