Autofill OSX: Add PermanentErrorMessage box and label.

Autofill OSX: Add PermanentErrorMessage box and label.

Adds red permanent error message banner between title and instructions.
Error messages passed to
CardUnmaskPromptViewBridge::GotVerificationResult() with
allow_retry == false are displayed. The banner is hidden until an error
message is passed to GotVerificationResult().

Note that the red banner does not extend to the full width of the dialog
(see screenshot attached to bug). Extending to the full dialog width
requires significant refactoring of the layout code, so I'm doing it in
two parts. This CL adds the banner functionality, and a separate CL will
fix the layout.

Dialog will re-layout to fit entire message if a multiline message is
set.

Also adds an ASCII art diagram of the dialog layout.

Screenshot attached to bug: https://code.google.com/p/chromium/issues/detail?id=448572#c15

BUG=448572
Committed: https://crrev.com/48a0519f92bfedc80eecef85436f707ab068ccbf
Cr-Commit-Position: refs/heads/master@{#322441}

[bondd, 2015-03-25 02:52:01]

Patchset #1 (id:1) has been deleted

[bondd, 2015-03-25 02:59:43]

bondd@chromium.org changed reviewers:
+ estade@chromium.org, groby@chromium.org

[bondd, 2015-03-25 02:59:43]

bondd@chromium.org changed required reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2015-03-25 19:32:36]

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:222: -
(void)setPermanentErrorMessage:(const base::string16&)text {
OK, I still have to harp on the naming. setRetriable is... weird. Think about
"setTransientErrorMessage". (Not for this CL, but in general)

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:341: // |    
(Both enclosed in storageView_.)           |
Yay! +1 for ASCII diagrams! (No, really - this is awesome)

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:376: CGFloat
minY = NSMaxY([instructionsLabel_ frame]) + chrome_style::kRowPadding;
[permanentErrorBox_ setFrame:NSMakeRect(0, minY, contentWidth, 0)];
CGFloat errorContentWidth =NSWidth([[permanentErrorBox_ contentView] frame]);
[... sizeTextField:errorLabel_ toFitWidth:errorContentWidth];
[permanentErrorBox sizeToFit];

That should do the trick without margin computations, correct? If you set the
errorLabel to autoresize, you can even skip the content width computation and
just do
[... sizeTextField:label_ toFitWidth:NSWidth([label_ frame])];

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:380:
[CardUnmaskPromptViewCocoa sizeTextField:permanentErrorLabel_
Sorry. My brain was stuck. This functionality exists:

[GTMUILayoutTweaker sizeToFitFixedWidthTextField:label_];

Or l10n_util::WrapOrSizeToFit(label_);

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:387: minY =
NSMaxY([permanentErrorBox_ frame]) + chrome_style::kRowPadding;
I'm tempted to suggest a "NextRow" helper.

[bondd, 2015-03-26 00:17:59]

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:222: -
(void)setPermanentErrorMessage:(const base::string16&)text {
On 2015/03/25 19:32:35, groby wrote:
> OK, I still have to harp on the naming. setRetriable is... weird. Think about
> "setTransientErrorMessage". (Not for this CL, but in general)

Acknowledged.

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:341: // |    
(Both enclosed in storageView_.)           |
On 2015/03/25 19:32:35, groby wrote:
> Yay! +1 for ASCII diagrams! (No, really - this is awesome)

Woo!

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:376: CGFloat
minY = NSMaxY([instructionsLabel_ frame]) + chrome_style::kRowPadding;
On 2015/03/25 19:32:35, groby wrote:
> [permanentErrorBox_ setFrame:NSMakeRect(0, minY, contentWidth, 0)];
> CGFloat errorContentWidth =NSWidth([[permanentErrorBox_ contentView] frame]);
> [... sizeTextField:errorLabel_ toFitWidth:errorContentWidth];
> [permanentErrorBox sizeToFit];
> 
> That should do the trick without margin computations, correct? If you set the
> errorLabel to autoresize, you can even skip the content width computation and
> just do
> [... sizeTextField:label_ toFitWidth:NSWidth([label_ frame])];

Nice! Done.

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:380:
[CardUnmaskPromptViewCocoa sizeTextField:permanentErrorLabel_
On 2015/03/25 19:32:35, groby wrote:
> Sorry. My brain was stuck. This functionality exists:
> 
> [GTMUILayoutTweaker sizeToFitFixedWidthTextField:label_];
> 
> Or l10n_util::WrapOrSizeToFit(label_);

Done.

https://codereview.chromium.org/1038503003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:387: minY =
NSMaxY([permanentErrorBox_ frame]) + chrome_style::kRowPadding;
On 2015/03/25 19:32:35, groby wrote:
> I'm tempted to suggest a "NextRow" helper.

Acknowledged. This layout code is in flux right now and will undergo another
refactoring within the next week (to allow permanentErrorBox_ to extend the full
width of the dialog). Unless I hear otherwise I'll leave NextRow out for now,
and keep it in mind to see if it's still needed during the refactoring.

[groby-ooo-7-16, 2015-03-26 01:35:27]

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:31: const
SkColor kPermanentErrorTextColor = 0xffffffff;
SkColor_WHITE;

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:32: const
SkColor kPermanentErrorBackgroundColor = 0xffd32f2f;
SkColorSetRGB(0xd3, 0x2f, 0x2f)

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:101:
[view_controller_ setRetriableErrorMessage:base::string16()];
Shouldn't -setPermanentErrorMessage automatically reset the transient one?

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:399: [self
performLayoutAndDisplay:YES];
You call this only once - can you just inline?

[bondd, 2015-03-26 02:54:29]

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (right):

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:31: const
SkColor kPermanentErrorTextColor = 0xffffffff;
On 2015/03/26 01:35:27, groby wrote:
> SkColor_WHITE;

Done.

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:32: const
SkColor kPermanentErrorBackgroundColor = 0xffd32f2f;
On 2015/03/26 01:35:27, groby wrote:
> SkColorSetRGB(0xd3, 0x2f, 0x2f)

Done.

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:101:
[view_controller_ setRetriableErrorMessage:base::string16()];
On 2015/03/26 01:35:27, groby wrote:
> Shouldn't -setPermanentErrorMessage automatically reset the transient one?

Done. This gets rid of the -performLayout call too.

https://codereview.chromium.org/1038503003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:399: [self
performLayoutAndDisplay:YES];
On 2015/03/26 01:35:27, groby wrote:
> You call this only once - can you just inline?

Done.

[groby-ooo-7-16, 2015-03-26 17:53:39]

lgtm

[bondd, 2015-03-26 18:03:29]

The CQ bit was checked by bondd@chromium.org

[commit-bot: I haz the power, 2015-03-26 18:04:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1038503003/60001

[commit-bot: I haz the power, 2015-03-26 19:10:13]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-26 19:10:57]

Patchset 3 (id:??) landed as
https://crrev.com/48a0519f92bfedc80eecef85436f707ab068ccbf
Cr-Commit-Position: refs/heads/master@{#322441}