Autofill OSX: Add PermanentErrorMessage box and label.

chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_controller.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h"
 #include "chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h"
 #import "chrome/browser/ui/cocoa/key_equivalent_constants.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "ui/base/cocoa/window_size_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 const CGFloat kButtonGap = 6.0f;
 const CGFloat kDialogContentMinWidth = 210.0f;
 const CGFloat kCvcInputWidth = 64.0f;
+const SkColor kPermanentErrorTextColor = 0xffffffff;
+const SkColor kPermanentErrorBackgroundColor = 0xffd32f2f;
 const ui::ResourceBundle::FontStyle kProgressFontStyle =
     chrome_style::kTitleFontStyle;
 const ui::ResourceBundle::FontStyle kErrorFontStyle =
     chrome_style::kTextFontStyle;
 
 }  // namespace
 
 namespace autofill {
 
 // static
@@ skipping 41 matching lines @@
     [view_controller_ setProgressOverlayText:
                           l10n_util::GetStringUTF16(
                               IDS_AUTOFILL_CARD_UNMASK_VERIFICATION_SUCCESS)];
 
     base::MessageLoop::current()->PostDelayedTask(
         FROM_HERE, base::Bind(&CardUnmaskPromptViewBridge::PerformClose,
                               weak_ptr_factory_.GetWeakPtr()),
         base::TimeDelta::FromSeconds(1));
   } else {
     [view_controller_ setProgressOverlayText:base::string16()];
-    // TODO(bondd): Views version never hides |errorLabel_|. When Views decides
-    // when to hide it then do the same thing here.
-    [view_controller_ setRetriableErrorMessage:error_message];
+
+    if (allow_retry) {
+      // TODO(bondd): Views version never hides |errorLabel_|. When Views
+      // decides when to hide it then do the same thing here.
+      [view_controller_ setRetriableErrorMessage:error_message];
+    } else {
+      [view_controller_ setPermanentErrorMessage:error_message];
+      [view_controller_ setRetriableErrorMessage:base::string16()];
+    }
+    [view_controller_ performLayout];
   }
 }
 
 void CardUnmaskPromptViewBridge::OnConstrainedWindowClosed(
     ConstrainedWindowMac* window) {
   if (controller_)
     controller_->OnUnmaskDialogClosed();
   base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
 
 CardUnmaskPromptController* CardUnmaskPromptViewBridge::GetController() {
   return controller_;
 }
 
 void CardUnmaskPromptViewBridge::PerformClose() {
   constrained_window_->CloseWebContentsModalDialog();
 }
 
 }  // autofill
 
 #pragma mark CardUnmaskPromptViewCocoa
 
 @implementation CardUnmaskPromptViewCocoa {
+  base::scoped_nsobject<NSBox> permanentErrorBox_;
   base::scoped_nsobject<NSView> inputRowView_;
   base::scoped_nsobject<NSView> storageView_;
 
   base::scoped_nsobject<NSTextField> titleLabel_;
+  base::scoped_nsobject<NSTextField> permanentErrorLabel_;
   base::scoped_nsobject<NSTextField> instructionsLabel_;
   base::scoped_nsobject<NSTextField> cvcInput_;
   base::scoped_nsobject<NSPopUpButton> monthPopup_;
   base::scoped_nsobject<NSPopUpButton> yearPopup_;
   base::scoped_nsobject<NSButton> cancelButton_;
   base::scoped_nsobject<NSButton> verifyButton_;
   base::scoped_nsobject<NSButton> storageCheckbox_;
   base::scoped_nsobject<AutofillTooltipController> storageTooltip_;
   base::scoped_nsobject<NSTextField> errorLabel_;
   base::scoped_nsobject<NSTextField> progressOverlayLabel_;
@@ skipping 68 matching lines @@
   [inputRowView_ setHidden:!text.empty()];
   [self updateVerifyButtonEnabled];
 }
 
 - (void)setRetriableErrorMessage:(const base::string16&)text {
   NSAttributedString* attributedString =
       constrained_window::GetAttributedLabelString(
           SysUTF16ToNSString(text), kErrorFontStyle, NSNaturalTextAlignment,
           NSLineBreakByWordWrapping);
   [errorLabel_ setAttributedStringValue:attributedString];
-  [self performLayoutAndDisplay:YES];
+}
+
+- (void)setPermanentErrorMessage:(const base::string16&)text {

[groby-ooo-7-16, 2015/03/25 19:32:35]

OK, I still have to harp on the naming. setRetriable is... weird. Think about
"setTransientErrorMessage". (Not for this CL, but in general)

[bondd, 2015/03/26 00:17:59]

Acknowledged.

+  if (!text.empty()) {
+    if (!permanentErrorBox_) {
+      permanentErrorBox_.reset([[NSBox alloc] initWithFrame:NSZeroRect]);
+      [permanentErrorBox_ setBoxType:NSBoxCustom];
+      [permanentErrorBox_ setBorderType:NSNoBorder];
+      [permanentErrorBox_ setTitlePosition:NSNoTitle];
+      [permanentErrorBox_ setFillColor:gfx::SkColorToCalibratedNSColor(
+                                           kPermanentErrorBackgroundColor)];
+
+      permanentErrorLabel_.reset([constrained_window::CreateLabel() retain]);
+      [permanentErrorLabel_ setTextColor:gfx::SkColorToCalibratedNSColor(
+                                             kPermanentErrorTextColor)];
+
+      [permanentErrorBox_ addSubview:permanentErrorLabel_];
+      [[self view] addSubview:permanentErrorBox_];
+    }
+
+    NSAttributedString* attributedString =
+        constrained_window::GetAttributedLabelString(
+            SysUTF16ToNSString(text), kErrorFontStyle, NSNaturalTextAlignment,
+            NSLineBreakByWordWrapping);
+    [permanentErrorLabel_ setAttributedStringValue:attributedString];
+  }
+
+  [permanentErrorBox_ setHidden:text.empty()];
 }
 
 - (void)updateVerifyButtonEnabled {
   autofill::CardUnmaskPromptController* controller = bridge_->GetController();
   DCHECK(controller);
 
   BOOL enable =
       ![inputRowView_ isHidden] &&
       controller->InputCvcIsValid(
           base::SysNSStringToUTF16([cvcInput_ stringValue])) &&
@@ skipping 56 matching lines @@
                      IDS_AUTOFILL_CARD_UNMASK_PROMPT_STORAGE_TOOLTIP))];
   [view addSubview:[storageTooltip_ view]];
   [[storageTooltip_ view] setFrameOrigin:
       NSMakePoint(NSMaxX([storageCheckbox_ frame]) + kButtonGap, 0)];
 
   [CardUnmaskPromptViewCocoa sizeToFitView:view];
   [CardUnmaskPromptViewCocoa verticallyCenterSubviewsInView:view];
   return view;
 }
 
-// TODO(bondd): Add an ASCII diagram of the layout.
+// +------------------------------------------------+
+// | titleLabel_        (Single line.)              |
+// |------------------------------------------------|
+// | permanentErrorBox_ (Multiline, may be hidden.) |
+// |------------------------------------------------|
+// | instructionsLabel_ (Multiline.)                |
+// |------------------------------------------------|
+// | monthPopup_ yearPopup_ cvcInput_ cvcImage      |
+// |     (All enclosed in inputRowView_. Month and  |
+// |         year may be hidden.)                   |
+// |------------------------------------------------|
+// | errorLabel_ (Multiline. Always takes up space  |
+// |                 for one line even if empty.)   |
+// |------------------------------------------------|
+// |                              [Cancel] [Verify] |
+// |------------------------------------------------|
+// | storageCheckbox_ storageTooltip_               |
+// |     (Both enclosed in storageView_.)           |

[groby-ooo-7-16, 2015/03/25 19:32:35]

Yay! +1 for ASCII diagrams! (No, really - this is awesome)

[bondd, 2015/03/26 00:17:59]

Woo!

+// +------------------------------------------------+
 - (void)performLayoutAndDisplay:(BOOL)display {
   // Calculate dialog content width.
   CGFloat contentWidth =
       std::max(NSWidth([titleLabel_ frame]), NSWidth([inputRowView_ frame]));
   contentWidth = std::max(contentWidth, NSWidth([storageView_ frame]));
   contentWidth = std::max(contentWidth, kDialogContentMinWidth);
 
   [storageView_
       setFrameOrigin:NSMakePoint(0, chrome_style::kClientBottomPadding)];
 
@@ skipping 12 matching lines @@
 
   [inputRowView_ setFrameOrigin:NSMakePoint(0, NSMaxY([errorLabel_ frame]) +
                                                    chrome_style::kRowPadding)];
 
   [instructionsLabel_
       setFrameOrigin:NSMakePoint(0, NSMaxY([inputRowView_ frame]) +
                                         chrome_style::kRowPadding)];
   [CardUnmaskPromptViewCocoa sizeTextField:instructionsLabel_
                                 toFitWidth:contentWidth];
 
-  [titleLabel_
-      setFrameOrigin:NSMakePoint(0, NSMaxY([instructionsLabel_ frame]) +
-                                        chrome_style::kRowPadding)];
+  // Layout permanent error box.
+  CGFloat minY = NSMaxY([instructionsLabel_ frame]) + chrome_style::kRowPadding;

[groby-ooo-7-16, 2015/03/25 19:32:35]

[permanentErrorBox_ setFrame:NSMakeRect(0, minY, contentWidth, 0)];
CGFloat errorContentWidth =NSWidth([[permanentErrorBox_ contentView] frame]);
[... sizeTextField:errorLabel_ toFitWidth:errorContentWidth];
[permanentErrorBox sizeToFit];

That should do the trick without margin computations, correct? If you set the
errorLabel to autoresize, you can even skip the content width computation and
just do
[... sizeTextField:label_ toFitWidth:NSWidth([label_ frame])];

[bondd, 2015/03/26 00:17:59]

Nice! Done.

+  if (permanentErrorBox_ && ![permanentErrorBox_ isHidden]) {
+    CGFloat errorBoxContentWidth =
+        contentWidth - [permanentErrorBox_ contentViewMargins].width * 2.0;
+    [CardUnmaskPromptViewCocoa sizeTextField:permanentErrorLabel_

[groby-ooo-7-16, 2015/03/25 19:32:35]

Sorry. My brain was stuck. This functionality exists:

[GTMUILayoutTweaker sizeToFitFixedWidthTextField:label_];

Or l10n_util::WrapOrSizeToFit(label_);

[bondd, 2015/03/26 00:17:59]

Done.

+                                  toFitWidth:errorBoxContentWidth];
+
+    [permanentErrorBox_ sizeToFit];
+    [permanentErrorBox_
+        setFrame:NSMakeRect(0, minY, contentWidth,
+                            NSHeight([permanentErrorBox_ frame]))];
+    minY = NSMaxY([permanentErrorBox_ frame]) + chrome_style::kRowPadding;

[groby-ooo-7-16, 2015/03/25 19:32:35]

I'm tempted to suggest a "NextRow" helper.

[bondd, 2015/03/26 00:17:59]

Acknowledged. This layout code is in flux right now and will undergo another
refactoring within the next week (to allow permanentErrorBox_ to extend the full
width of the dialog). Unless I hear otherwise I'll leave NextRow out for now,
and keep it in mind to see if it's still needed during the refactoring.

+  }
+
+  [titleLabel_ setFrameOrigin:NSMakePoint(0, minY)];
 
   // Center progressOverlayLabel_ vertically within inputRowView_ frame.
   CGFloat progressHeight = ui::ResourceBundle::GetSharedInstance()
                                .GetFont(kProgressFontStyle)
                                .GetHeight();
   [progressOverlayLabel_
       setFrame:NSMakeRect(0, ceil(NSMidY([inputRowView_ frame]) -
                                   progressHeight / 2.0),
                           contentWidth, progressHeight)];
 
   // Set dialog size.
   [[self view]
       setFrameSize:NSMakeSize(
                        contentWidth + chrome_style::kHorizontalPadding * 2.0,
                        NSMaxY([titleLabel_ frame]) +
                            chrome_style::kTitleTopPadding)];
 
   NSRect frameRect =
       [[[self view] window] frameRectForContentRect:[[self view] frame]];
   [[[self view] window] setFrame:frameRect display:display];
 }
 
+- (void)performLayout {
+  [self performLayoutAndDisplay:YES];
+}
+
 - (void)loadView {
   autofill::CardUnmaskPromptController* controller = bridge_->GetController();
   DCHECK(controller);
 
   base::scoped_nsobject<NSBox> mainView(
       [[NSBox alloc] initWithFrame:NSZeroRect]);
   [mainView setBoxType:NSBoxCustom];
   [mainView setBorderType:NSNoBorder];
   [mainView setTitlePosition:NSNoTitle];
   [mainView
@@ skipping 118 matching lines @@
 
   // Layout inputRowView_.
   [CardUnmaskPromptViewCocoa sizeToFitView:inputRowView_];
   [CardUnmaskPromptViewCocoa verticallyCenterSubviewsInView:inputRowView_];
 
   [self setView:mainView];
   [self performLayoutAndDisplay:NO];
 }
 
 @end