Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 10382032: Coverity: Fix pass by value error. (Closed)

Created:
8 years, 7 months ago by kmadhusu
Modified:
8 years, 7 months ago
Reviewers:
mrossetti, brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Coverity: Fix pass by value error. CID=103734 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135695

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/history/url_index_private_data.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kmadhusu
8 years, 7 months ago (2012-05-07 06:21:33 UTC) #1
mrossetti
LGTM with change to comment. http://codereview.chromium.org/10382032/diff/1/chrome/browser/history/url_index_private_data.h File chrome/browser/history/url_index_private_data.h (right): http://codereview.chromium.org/10382032/diff/1/chrome/browser/history/url_index_private_data.h#newcode145 chrome/browser/history/url_index_private_data.h:145: // deliberately passed by ...
8 years, 7 months ago (2012-05-07 15:31:22 UTC) #2
kmadhusu
http://codereview.chromium.org/10382032/diff/1/chrome/browser/history/url_index_private_data.h File chrome/browser/history/url_index_private_data.h (right): http://codereview.chromium.org/10382032/diff/1/chrome/browser/history/url_index_private_data.h#newcode145 chrome/browser/history/url_index_private_data.h:145: // deliberately passed by value. On 2012/05/07 15:31:22, mrossetti ...
8 years, 7 months ago (2012-05-07 17:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10382032/4002
8 years, 7 months ago (2012-05-07 17:43:52 UTC) #4
commit-bot: I haz the power
Presubmit check for 10382032-4002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-07 17:43:56 UTC) #5
kmadhusu
brettw@: OWNERS check failed. Can you lgtm this CL? Thanks.
8 years, 7 months ago (2012-05-07 17:48:29 UTC) #6
brettw
lgtm
8 years, 7 months ago (2012-05-07 17:49:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10382032/4002
8 years, 7 months ago (2012-05-07 17:50:33 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-07 19:21:22 UTC) #9
Change committed as 135695

Powered by Google App Engine
This is Rietveld 408576698