Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7319)

Unified Diff: chrome/browser/history/url_index_private_data.h

Issue 10382032: Coverity: Fix pass by value error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/history/url_index_private_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/url_index_private_data.h
diff --git a/chrome/browser/history/url_index_private_data.h b/chrome/browser/history/url_index_private_data.h
index 58d51303415f4f42152db2fcdd2bc02978d5113b..c09b72557dfede173d0993ea7974b48838476101 100644
--- a/chrome/browser/history/url_index_private_data.h
+++ b/chrome/browser/history/url_index_private_data.h
@@ -141,12 +141,11 @@ class URLIndexPrivateData
// Creates a new URLIndexPrivateData object, populates it from the contents
// of the cache file stored in |file_path|, and assigns it to |private_data|.
- // |languages| will be used to break URLs and page titles into words and is
- // deliberately passed by value.
+ // |languages| will be used to break URLs and page titles into words.
static void RestoreFromFileTask(
const FilePath& file_path,
scoped_refptr<URLIndexPrivateData> private_data,
- std::string languages);
+ const std::string& languages);
// Constructs a new object by restoring its contents from the file at |path|.
// Returns the new URLIndexPrivateData which on success will contain the
« no previous file with comments | « no previous file | chrome/browser/history/url_index_private_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698