chrome/browser/history/url_index_private_data.cc - Issue 10382032: Coverity: Fix pass by value error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/url_index_private_data.cc

Issue 10382032: Coverity: Fix pass by value error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/url_index_private_data.cc

diff --git a/chrome/browser/history/url_index_private_data.cc b/chrome/browser/history/url_index_private_data.cc

index 0e4cfa60e691bb8d72165565bce54987fee001d2..f7050f7f386f805770fb04022c7227c4ac1e7ea5 100644

--- a/chrome/browser/history/url_index_private_data.cc

+++ b/chrome/browser/history/url_index_private_data.cc

@@ -1095,7 +1095,7 @@ void URLIndexPrivateData::SaveWordStartsMap(

void URLIndexPrivateData::RestoreFromFileTask(

const FilePath& file_path,

scoped_refptr<URLIndexPrivateData> private_data,

- std::string languages) {

+ const std::string& languages) {

private_data = URLIndexPrivateData::RestoreFromFile(file_path, languages);

}

« no previous file with comments | « chrome/browser/history/url_index_private_data.h ('k') | no next file » | no next file with comments »