Issue 1037533002: Make initialization of the QuicInMemoryCache explicit to avoid spooky action at a distance which co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1037533002: Make initialization of the QuicInMemoryCache explicit to avoid spooky action at a distance which co… (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton

Modified:
5 years, 9 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make initialization of the QuicInMemoryCache explicit to avoid spooky action at a distance which complicates testing. Merge internal change: 89416965 R=rtenneti@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -54 lines)			Patch
M	net/tools/quic/quic_in_memory_cache.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	net/tools/quic/quic_in_memory_cache.cc	View	4 chunks	+19 lines, -23 lines	2 comments	Download
M	net/tools/quic/quic_in_memory_cache_test.cc	View	4 chunks	+19 lines, -18 lines	0 comments	Download
M	net/tools/quic/quic_server.cc	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream_test.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

lgtm https://codereview.chromium.org/1037533002/diff/1/net/tools/quic/quic_in_memory_cache.cc File net/tools/quic/quic_in_memory_cache.cc (right): https://codereview.chromium.org/1037533002/diff/1/net/tools/quic/quic_in_memory_cache.cc#newcode112 net/tools/quic/quic_in_memory_cache.cc:112: << cache_directory; nit: indentation.

5 years, 9 months ago (2015-03-24 21:49:36 UTC) #2

Ryan Hamilton

5 years, 9 months ago (2015-03-24 22:03:10 UTC) #3

Thanks!

https://codereview.chromium.org/1037533002/diff/1/net/tools/quic/quic_in_memo...
File net/tools/quic/quic_in_memory_cache.cc (right):

https://codereview.chromium.org/1037533002/diff/1/net/tools/quic/quic_in_memo...
net/tools/quic/quic_in_memory_cache.cc:112: << cache_directory;
On 2015/03/24 21:49:36, ramant wrote:
> nit: indentation.

Done. (In final CL)

Expand Messages | Collapse Messages