Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: net/tools/quic/quic_spdy_server_stream_test.cc

Issue 1037533002: Make initialization of the QuicInMemoryCache explicit to avoid spooky action at a distance which co… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/tools/quic/quic_in_memory_cache.cc ('K') | « net/tools/quic/quic_server.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_server_stream_test.cc
diff --git a/net/tools/quic/quic_spdy_server_stream_test.cc b/net/tools/quic/quic_spdy_server_stream_test.cc
index 5e57820a13018d4b199f44e29827889d361f4dc5..9db838a93b35d00f514d6afd22ffdf6bc8ea6a04 100644
--- a/net/tools/quic/quic_spdy_server_stream_test.cc
+++ b/net/tools/quic/quic_spdy_server_stream_test.cc
@@ -91,13 +91,7 @@ class QuicSpdyServerStreamTest : public ::testing::TestWithParam<QuicVersion> {
session_.config()->SetInitialSessionFlowControlWindowToSend(
kInitialSessionFlowControlWindowForTest);
stream_.reset(new QuicSpdyServerStreamPeer(3, &session_));
- }
-
- static void SetUpTestCase() {
- QuicInMemoryCachePeer::ResetForTests();
- }
- void SetUp() override {
QuicInMemoryCachePeer::ResetForTests();
string host = "";
string path = "/foo";
@@ -107,6 +101,10 @@ class QuicSpdyServerStreamTest : public ::testing::TestWithParam<QuicVersion> {
body);
}
+ ~QuicSpdyServerStreamTest() override {
+ QuicInMemoryCachePeer::ResetForTests();
+ }
+
const string& StreamBody() {
return QuicSpdyServerStreamPeer::body(stream_.get());
}
« net/tools/quic/quic_in_memory_cache.cc ('K') | « net/tools/quic/quic_server.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698