Make initialization of the QuicInMemoryCache explicit to avoid spooky action at a distance which co…

net/tools/quic/quic_in_memory_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TOOLS_QUIC_QUIC_IN_MEMORY_CACHE_H_
 #define NET_TOOLS_QUIC_QUIC_IN_MEMORY_CACHE_H_
 
 #include <string>
 
 #include "base/containers/hash_tables.h"
 #include "base/memory/singleton.h"
 #include "base/strings/string_piece.h"
 #include "net/spdy/spdy_framer.h"
 
 template <typename T> struct DefaultSingletonTraits;
 
 namespace net {
 namespace tools {
 
 namespace test {
 class QuicInMemoryCachePeer;
 }  // namespace
 
-extern std::string FLAGS_quic_in_memory_cache_dir;
-
 class QuicServer;
 
 // In-memory cache for HTTP responses.
 // Reads from disk cache generated by:
 // `wget -p --save_headers <url>`
 class QuicInMemoryCache {
  public:
   enum SpecialResponseType {
     REGULAR_RESPONSE,  // Send the headers and body like a server should.
     CLOSE_CONNECTION,  // Close the connection (sending the close packet).
@@ skipping 50 matching lines @@
   void AddResponse(base::StringPiece host,
                    base::StringPiece path,
                    const SpdyHeaderBlock& response_headers,
                    base::StringPiece response_body);
 
   // Simulate a special behavior at a particular path.
   void AddSpecialResponse(base::StringPiece host,
                           base::StringPiece path,
                           SpecialResponseType response_type);
 
+  // |cache_cirectory| can be generated using `wget -p --save-headers <url>`.
+  void InitializeFromDirectory(const std::string& cache_directory);
+
  private:
   typedef base::hash_map<std::string, Response*> ResponseMap;
   friend struct DefaultSingletonTraits<QuicInMemoryCache>;
   friend class test::QuicInMemoryCachePeer;
 
   QuicInMemoryCache();
   ~QuicInMemoryCache();
 
   void ResetForTests();
 
-  void Initialize();
-
   void AddResponseImpl(base::StringPiece host,
                        base::StringPiece path,
                        SpecialResponseType response_type,
                        const SpdyHeaderBlock& response_headers,
                        base::StringPiece response_body);
 
   std::string GetKey(base::StringPiece host, base::StringPiece path) const;
 
   // Cached responses.
   ResponseMap responses_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicInMemoryCache);
 };
 
 }  // namespace tools
 }  // namespace net
 
 #endif  // NET_TOOLS_QUIC_QUIC_IN_MEMORY_CACHE_H_