Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 103743004: Implement zone-allocated types (Closed)

Created:
7 years ago by rossberg
Modified:
6 years, 11 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Implement zone-allocated types More template magic FTW. R=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18543

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments; silenced x64 warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+955 lines, -713 lines) Patch
M src/list-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/types.h View 1 7 chunks +174 lines, -22 lines 0 comments Download
M src/types.cc View 1 14 chunks +52 lines, -48 lines 0 comments Download
M test/cctest/test-types.cc View 1 1 chunk +717 lines, -643 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
7 years ago (2013-12-18 16:52:22 UTC) #1
titzer
https://codereview.chromium.org/103743004/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/103743004/diff/1/src/types.h#newcode404 src/types.h:404: static Unioned* union_shrink(Unioned* unioned, int size, Zone* zone) { ...
7 years ago (2013-12-19 13:44:41 UTC) #2
rossberg
https://codereview.chromium.org/103743004/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/103743004/diff/1/src/types.h#newcode404 src/types.h:404: static Unioned* union_shrink(Unioned* unioned, int size, Zone* zone) { ...
7 years ago (2013-12-19 17:21:25 UTC) #3
titzer
lgtm
7 years ago (2013-12-19 18:47:24 UTC) #4
rossberg
6 years, 11 months ago (2014-01-10 14:43:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18543 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698