Remove unnecessary 'virtual' annotation from mojo

Remove unnecessary 'virtual' annotation from mojo

Removes virtual keyword from overridden methods in cpp_templates.

BUG=417463, 469785
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b3870915a415281db37d62f6ed1c4d66ab0d9cd0

[cwgreene, 2015-03-27 19:34:50]

cwgreene@amazon.com changed reviewers:
+ jamesr@chromium.org, sky@chromium.org

[cwgreene, 2015-03-27 19:34:50]

PTAL :)

[viettrungluu, 2015-03-27 19:45:06]

viettrungluu@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-03-27 19:45:06]

https://codereview.chromium.org/1037353002/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/1037353002/diff/1/AUTHORS#newcode88
AUTHORS:88: Chris Greene <cwgreene@amazon.com>
Have you signed the CLA? (You haven't as far as I can tell, but I may be
mistaken.)

https://cla.developers.google.com/clas

https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
File
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
(right):

https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl:9:
mojo::MessageReceiver* responder) override;
nit: fix indentation

[cwgreene, 2015-03-27 20:25:57]

On 2015/03/27 19:45:06, viettrungluu wrote:
> https://codereview.chromium.org/1037353002/diff/1/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/1037353002/diff/1/AUTHORS#newcode88
> AUTHORS:88: Chris Greene <mailto:cwgreene@amazon.com>
> Have you signed the CLA? (You haven't as far as I can tell, but I may be
> mistaken.)
> 
> https://cla.developers.google.com/clas
> 
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> File
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
> (right):
> 
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl:9:
> mojo::MessageReceiver* responder) override;
> nit: fix indentation

CLA completion pending.

[viettrungluu, 2015-03-27 21:31:05]

Thanks. LGTM on the change itself, but I guess to be kosher we should wait until
the CLA goes through before landing.

On 2015/03/27 20:25:57, cwgreene wrote:
> On 2015/03/27 19:45:06, viettrungluu wrote:
> > https://codereview.chromium.org/1037353002/diff/1/AUTHORS
> > File AUTHORS (right):
> > 
> > https://codereview.chromium.org/1037353002/diff/1/AUTHORS#newcode88
> > AUTHORS:88: Chris Greene <mailto:cwgreene@amazon.com>
> > Have you signed the CLA? (You haven't as far as I can tell, but I may be
> > mistaken.)
> > 
> > https://cla.developers.google.com/clas
> > 
> >
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> > File
> >
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
> > (right):
> > 
> >
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> >
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl:9:
> > mojo::MessageReceiver* responder) override;
> > nit: fix indentation
> 
> CLA completion pending.

[cwgreene, 2015-03-30 17:59:49]

The CLA has now been updated.

On 2015/03/27 21:31:05, viettrungluu wrote:
> Thanks. LGTM on the change itself, but I guess to be kosher we should wait
until
> the CLA goes through before landing.
> 
> On 2015/03/27 20:25:57, cwgreene wrote:
> > On 2015/03/27 19:45:06, viettrungluu wrote:
> > > https://codereview.chromium.org/1037353002/diff/1/AUTHORS
> > > File AUTHORS (right):
> > > 
> > > https://codereview.chromium.org/1037353002/diff/1/AUTHORS#newcode88
> > > AUTHORS:88: Chris Greene <mailto:cwgreene@amazon.com>
> > > Have you signed the CLA? (You haven't as far as I can tell, but I may be
> > > mistaken.)
> > > 
> > > https://cla.developers.google.com/clas
> > > 
> > >
> >
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> > > File
> > >
> >
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> > >
> >
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl:9:
> > > mojo::MessageReceiver* responder) override;
> > > nit: fix indentation
> > 
> > CLA completion pending.

[viettrungluu, 2015-03-30 18:01:42]

Excellent. Will land. Thanks again.

On 2015/03/30 17:59:49, cwgreene wrote:
> The CLA has now been updated.
> 
> On 2015/03/27 21:31:05, viettrungluu wrote:
> > Thanks. LGTM on the change itself, but I guess to be kosher we should wait
> until
> > the CLA goes through before landing.
> > 
> > On 2015/03/27 20:25:57, cwgreene wrote:
> > > On 2015/03/27 19:45:06, viettrungluu wrote:
> > > > https://codereview.chromium.org/1037353002/diff/1/AUTHORS
> > > > File AUTHORS (right):
> > > > 
> > > > https://codereview.chromium.org/1037353002/diff/1/AUTHORS#newcode88
> > > > AUTHORS:88: Chris Greene <mailto:cwgreene@amazon.com>
> > > > Have you signed the CLA? (You haven't as far as I can tell, but I may be
> > > > mistaken.)
> > > > 
> > > > https://cla.developers.google.com/clas
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> > > > File
> > > >
> > >
> >
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
> > > > (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1037353002/diff/1/mojo/public/tools/bindings/...
> > > >
> > >
> >
>
mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl:9:
> > > > mojo::MessageReceiver* responder) override;
> > > > nit: fix indentation
> > > 
> > > CLA completion pending.

[viettrungluu, 2015-03-30 18:02:25]

Committed patchset #2 (id:20001) manually as
b3870915a415281db37d62f6ed1c4d66ab0d9cd0 (presubmit successful).