Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1037353002: Remove unnecessary 'virtual' annotation from mojo (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fix indentation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
index 44d1428d00340edc9472a5e6f2bcba0a5854eca5..5214df9cfcc6bfb2cc8645ce8c53ff5f9b5080f8 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
@@ -46,7 +46,7 @@ class {{class_name}}_{{method.name}}_ForwardToCallback
const {{class_name}}::{{method.name}}Callback& callback)
: callback_(callback) {
}
- virtual bool Accept(mojo::Message* message) override;
+ bool Accept(mojo::Message* message) override;
private:
{{class_name}}::{{method.name}}Callback callback_;
MOJO_DISALLOW_COPY_AND_ASSIGN({{class_name}}_{{method.name}}_ForwardToCallback);
@@ -129,7 +129,7 @@ class {{class_name}}_{{method.name}}_ProxyToResponder
was_run_(false) {
}
- virtual void Run({{interface_macros.declare_params("in_", method.response_parameters)}}) const override;
+ void Run({{interface_macros.declare_params("in_", method.response_parameters)}}) const override;
private:
uint64_t request_id_;
« no previous file with comments | « AUTHORS ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698