Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1037353002: Remove unnecessary 'virtual' annotation from mojo (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fix indentation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {%- import "interface_macros.tmpl" as interface_macros %} 1 {%- import "interface_macros.tmpl" as interface_macros %}
2 {%- import "struct_macros.tmpl" as struct_macros %} 2 {%- import "struct_macros.tmpl" as struct_macros %}
3 {%- set class_name = interface.name %} 3 {%- set class_name = interface.name %}
4 {%- set proxy_name = interface.name ~ "Proxy" %} 4 {%- set proxy_name = interface.name ~ "Proxy" %}
5 {%- set namespace_as_string = "%s"|format(namespace|replace(".","::")) %} 5 {%- set namespace_as_string = "%s"|format(namespace|replace(".","::")) %}
6 6
7 {%- macro alloc_params(struct) %} 7 {%- macro alloc_params(struct) %}
8 {%- for param in struct.packed.packed_fields_in_ordinal_order %} 8 {%- for param in struct.packed.packed_fields_in_ordinal_order %}
9 {{param.field.kind|cpp_result_type}} p_{{param.field.name}}{}; 9 {{param.field.kind|cpp_result_type}} p_{{param.field.name}}{};
10 {%- endfor %} 10 {%- endfor %}
(...skipping 28 matching lines...) Expand all
39 {#--- ForwardToCallback definition #} 39 {#--- ForwardToCallback definition #}
40 {%- for method in interface.methods -%} 40 {%- for method in interface.methods -%}
41 {%- if method.response_parameters != None %} 41 {%- if method.response_parameters != None %}
42 class {{class_name}}_{{method.name}}_ForwardToCallback 42 class {{class_name}}_{{method.name}}_ForwardToCallback
43 : public mojo::MessageReceiver { 43 : public mojo::MessageReceiver {
44 public: 44 public:
45 {{class_name}}_{{method.name}}_ForwardToCallback( 45 {{class_name}}_{{method.name}}_ForwardToCallback(
46 const {{class_name}}::{{method.name}}Callback& callback) 46 const {{class_name}}::{{method.name}}Callback& callback)
47 : callback_(callback) { 47 : callback_(callback) {
48 } 48 }
49 virtual bool Accept(mojo::Message* message) override; 49 bool Accept(mojo::Message* message) override;
50 private: 50 private:
51 {{class_name}}::{{method.name}}Callback callback_; 51 {{class_name}}::{{method.name}}Callback callback_;
52 MOJO_DISALLOW_COPY_AND_ASSIGN({{class_name}}_{{method.name}}_ForwardToCallback ); 52 MOJO_DISALLOW_COPY_AND_ASSIGN({{class_name}}_{{method.name}}_ForwardToCallback );
53 }; 53 };
54 bool {{class_name}}_{{method.name}}_ForwardToCallback::Accept( 54 bool {{class_name}}_{{method.name}}_ForwardToCallback::Accept(
55 mojo::Message* message) { 55 mojo::Message* message) {
56 internal::{{class_name}}_{{method.name}}_ResponseParams_Data* params = 56 internal::{{class_name}}_{{method.name}}_ResponseParams_Data* params =
57 reinterpret_cast<internal::{{class_name}}_{{method.name}}_ResponseParams_D ata*>( 57 reinterpret_cast<internal::{{class_name}}_{{method.name}}_ResponseParams_D ata*>(
58 message->mutable_payload()); 58 message->mutable_payload());
59 59
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 } 122 }
123 123
124 {{class_name}}_{{method.name}}_ProxyToResponder( 124 {{class_name}}_{{method.name}}_ProxyToResponder(
125 uint64_t request_id, 125 uint64_t request_id,
126 mojo::MessageReceiver* responder) 126 mojo::MessageReceiver* responder)
127 : request_id_(request_id), 127 : request_id_(request_id),
128 responder_(responder), 128 responder_(responder),
129 was_run_(false) { 129 was_run_(false) {
130 } 130 }
131 131
132 virtual void Run({{interface_macros.declare_params("in_", method.response_para meters)}}) const override; 132 void Run({{interface_macros.declare_params("in_", method.response_parameters)} }) const override;
133 133
134 private: 134 private:
135 uint64_t request_id_; 135 uint64_t request_id_;
136 mutable mojo::MessageReceiver* responder_; 136 mutable mojo::MessageReceiver* responder_;
137 mutable bool was_run_; 137 mutable bool was_run_;
138 MOJO_DISALLOW_COPY_AND_ASSIGN({{class_name}}_{{method.name}}_ProxyToResponder) ; 138 MOJO_DISALLOW_COPY_AND_ASSIGN({{class_name}}_{{method.name}}_ProxyToResponder) ;
139 }; 139 };
140 void {{class_name}}_{{method.name}}_ProxyToResponder::Run( 140 void {{class_name}}_{{method.name}}_ProxyToResponder::Run(
141 {{interface_macros.declare_params("in_", method.response_parameters)}}) cons t { 141 {{interface_macros.declare_params("in_", method.response_parameters)}}) cons t {
142 was_run_ = true; 142 was_run_ = true;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 break; 279 break;
280 } 280 }
281 {%- endfor %} 281 {%- endfor %}
282 } 282 }
283 {%- endif %} 283 {%- endif %}
284 284
285 assert(sink_); 285 assert(sink_);
286 return sink_->Accept(message); 286 return sink_->Accept(message);
287 } 287 }
288 {%- endif -%} 288 {%- endif -%}
OLDNEW
« no previous file with comments | « AUTHORS ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698