Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1036773002: Reset RenderThreadImpl::gpu_va_context_provider_ before shuttind down the main message loop. (Closed)

Created:
5 years, 9 months ago by haraken
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset RenderThreadImpl::gpu_va_context_provider_ before shuttind down the main message loop. According to the stack trace in bug 467372, ~RenderThreadImpl() destructs RenderThreadImpl::gpu_va_context_provider_, which touches the main message loop that has been already shut down and crashes. To avoid the crash, this CL clears RenderThreadImpl::gpu_va_context_provider_ before RenderThreadImpl shuts down the main message loop. BUG=467372 Committed: https://crrev.com/b73174505bc418b2066037b54087a46c381436b0 Cr-Commit-Position: refs/heads/master@{#322188}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/render_thread_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
haraken
PTAL
5 years, 9 months ago (2015-03-25 15:10:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-25 15:47:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036773002/20001
5 years, 9 months ago (2015-03-25 16:35:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 17:48:56 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 17:49:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b73174505bc418b2066037b54087a46c381436b0
Cr-Commit-Position: refs/heads/master@{#322188}

Powered by Google App Engine
This is Rietveld 408576698