Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1036593003: Add VERBOSE->INFO logging level mapping to ExtensionInfoGenerator. (Closed)

Created:
5 years, 9 months ago by Kevin M
Modified:
5 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, apacible
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add VERBOSE->INFO logging level mapping to ExtensionInfoGenerator. Modify unit test to regress crashing bug and verify the fix. BUG=469935 Committed: https://crrev.com/9fc8806225dbfe2b33ca0af0ad27ded7e55b66f6 Cr-Commit-Position: refs/heads/master@{#322649}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review feedback & resync with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/extensions/api/developer_private/extension_info_generator.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc View 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Kevin M
5 years, 9 months ago (2015-03-25 17:38:47 UTC) #2
Devlin
lgtm with comment https://codereview.chromium.org/1036593003/diff/1/chrome/browser/extensions/api/developer_private/extension_info_generator.cc File chrome/browser/extensions/api/developer_private/extension_info_generator.cc (right): https://codereview.chromium.org/1036593003/diff/1/chrome/browser/extensions/api/developer_private/extension_info_generator.cc#newcode106 chrome/browser/extensions/api/developer_private/extension_info_generator.cc:106: case logging::LOG_VERBOSE: Hmm. Used to be ...
5 years, 9 months ago (2015-03-25 18:06:07 UTC) #3
Kevin M
https://codereview.chromium.org/1036593003/diff/1/chrome/browser/extensions/api/developer_private/extension_info_generator.cc File chrome/browser/extensions/api/developer_private/extension_info_generator.cc (right): https://codereview.chromium.org/1036593003/diff/1/chrome/browser/extensions/api/developer_private/extension_info_generator.cc#newcode106 chrome/browser/extensions/api/developer_private/extension_info_generator.cc:106: case logging::LOG_VERBOSE: On 2015/03/25 18:06:07, Devlin wrote: > Hmm. ...
5 years, 9 months ago (2015-03-27 21:05:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036593003/20001
5 years, 9 months ago (2015-03-27 21:06:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 21:49:42 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 21:50:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9fc8806225dbfe2b33ca0af0ad27ded7e55b66f6
Cr-Commit-Position: refs/heads/master@{#322649}

Powered by Google App Engine
This is Rietveld 408576698