chrome/browser/extensions/api/developer_private/extension_info_generator.cc - Issue 1036593003: Add VERBOSE->INFO logging level mapping to ExtensionInfoGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Issue 1036593003: Add VERBOSE->INFO logging level mapping to ExtensionInfoGenerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback & resync with master Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

index 4c96f9f0ed8a7e4795cc4a5fb3e0398798b4f39f..81bf3a5684a2079847a541afb504588a20ea87d3 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

@@ -103,12 +103,14 @@ linked_ptr<developer::RuntimeError> ConstructRuntimeError(

linked_ptr<developer::RuntimeError> result(new developer::RuntimeError());

PopulateErrorBase(error, result.get());

switch (error.level()) {

+ case logging::LOG_VERBOSE:

case logging::LOG_INFO:

result->severity = developer::ERROR_LEVEL_LOG;

break;

case logging::LOG_WARNING:

result->severity = developer::ERROR_LEVEL_WARN;

break;

+ case logging::LOG_FATAL:

case logging::LOG_ERROR:

result->severity = developer::ERROR_LEVEL_ERROR;

break;

« no previous file with comments | « no previous file | chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc » ('j') | no next file with comments »