Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

Issue 1036593003: Add VERBOSE->INFO logging level mapping to ExtensionInfoGenerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback & resync with master Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/developer_private/extension_info_generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
index 16bf1fe15af1903b83a31499aaeae4dd58bce564..eece9df0c2c088b0f476b0345f038f0b8624ee56 100644
--- a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
@@ -184,6 +184,20 @@ TEST_F(ExtensionInfoGeneratorUnitTest, BasicInfoTest) {
base::UTF8ToUTF16("message"),
base::UTF8ToUTF16("key"),
base::string16())));
+ error_console->ReportError(
+ make_scoped_ptr(new RuntimeError(
+ extension->id(),
+ false,
+ base::UTF8ToUTF16("source"),
+ base::UTF8ToUTF16("message"),
+ StackTrace(1, StackFrame(1,
+ 1,
+ base::UTF8ToUTF16("source"),
+ base::UTF8ToUTF16("function"))),
+ GURL("url"),
+ logging::LOG_VERBOSE,
+ 1,
+ 1)));
// It's not feasible to validate every field here, because that would be
// a duplication of the logic in the method itself. Instead, test a handful
@@ -204,7 +218,7 @@ TEST_F(ExtensionInfoGeneratorUnitTest, BasicInfoTest) {
EXPECT_FALSE(info->file_access.is_active);
EXPECT_TRUE(info->incognito_access.is_enabled);
EXPECT_FALSE(info->incognito_access.is_active);
- ASSERT_EQ(1u, info->runtime_errors.size());
+ ASSERT_EQ(2u, info->runtime_errors.size());
const api::developer_private::RuntimeError& runtime_error =
*info->runtime_errors[0];
EXPECT_EQ(extension->id(), runtime_error.extension_id);
@@ -213,6 +227,10 @@ TEST_F(ExtensionInfoGeneratorUnitTest, BasicInfoTest) {
runtime_error.severity);
EXPECT_EQ(1u, runtime_error.stack_trace.size());
ASSERT_EQ(1u, info->manifest_errors.size());
+ const api::developer_private::RuntimeError& runtime_error_verbose =
+ *info->runtime_errors[1];
+ EXPECT_EQ(api::developer_private::ERROR_LEVEL_LOG,
+ runtime_error_verbose.severity);
const api::developer_private::ManifestError& manifest_error =
*info->manifest_errors[0];
EXPECT_EQ(extension->id(), manifest_error.extension_id);
« no previous file with comments | « chrome/browser/extensions/api/developer_private/extension_info_generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698