Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1035793002: [DevTools] Only create DevToolsAgentHost for main frame and cross-process subframes. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman, yurys, nasko
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-to-frame
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Only create DevToolsAgentHost for main frame and cross-process subframes. BUG=464993 Committed: https://crrev.com/40ce1c665be6e955ffb0609fb48cabe951f34e6c Cr-Commit-Position: refs/heads/master@{#322359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 5 chunks +16 lines, -4 lines 0 comments Download
M content/browser/devtools/site_per_process_devtools_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Could you please take a look?
5 years, 9 months ago (2015-03-25 17:58:55 UTC) #2
nasko
Looks good, but pfeldman@ is probably more appropriate reviewer.
5 years, 9 months ago (2015-03-25 22:42:49 UTC) #3
yurys
lgtm
5 years, 9 months ago (2015-03-26 08:13:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035793002/1
5 years, 9 months ago (2015-03-26 10:32:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 11:58:26 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 11:59:04 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/40ce1c665be6e955ffb0609fb48cabe951f34e6c
Cr-Commit-Position: refs/heads/master@{#322359}

Powered by Google App Engine
This is Rietveld 408576698