Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 1035793002: [DevTools] Only create DevToolsAgentHost for main frame and cross-process subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-to-frame
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/site_per_process_devtools_browsertest.cc
diff --git a/content/browser/devtools/site_per_process_devtools_browsertest.cc b/content/browser/devtools/site_per_process_devtools_browsertest.cc
index aaa935f744fca39d2a34d0bfe159eefedf3148dd..1ec78c603c51f6975736c6f36c51897db8b43e96 100644
--- a/content/browser/devtools/site_per_process_devtools_browsertest.cc
+++ b/content/browser/devtools/site_per_process_devtools_browsertest.cc
@@ -103,9 +103,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,
EXPECT_EQ(1U, list.size());
EXPECT_EQ(DevToolsAgentHost::TYPE_WEB_CONTENTS, list[0]->GetType());
EXPECT_EQ(main_url.spec(), list[0]->GetURL().spec());
- // TODO(dgozman): we should get closed notification here.
- // See http://crbug.com/464993.
- EXPECT_FALSE(client.closed());
+ EXPECT_TRUE(client.closed());
child_host->DetachClient();
child_host = nullptr;
}
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698