Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 1035793002: [DevTools] Only create DevToolsAgentHost for main frame and cross-process subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-to-frame
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #include "content/browser/frame_host/frame_tree.h" 6 #include "content/browser/frame_host/frame_tree.h"
7 #include "content/browser/site_per_process_browsertest.h" 7 #include "content/browser/site_per_process_browsertest.h"
8 #include "content/browser/web_contents/web_contents_impl.h" 8 #include "content/browser/web_contents/web_contents_impl.h"
9 #include "content/public/browser/devtools_agent_host.h" 9 #include "content/public/browser/devtools_agent_host.h"
10 #include "content/public/test/content_browser_test_utils.h" 10 #include "content/public/test/content_browser_test_utils.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 TestClient client; 96 TestClient client;
97 child_host->AttachClient(&client); 97 child_host->AttachClient(&client);
98 98
99 // Load back same-site page into iframe. 99 // Load back same-site page into iframe.
100 NavigateFrameToURL(root->child_at(0), http_url); 100 NavigateFrameToURL(root->child_at(0), http_url);
101 101
102 list = DevToolsAgentHost::GetOrCreateAll(); 102 list = DevToolsAgentHost::GetOrCreateAll();
103 EXPECT_EQ(1U, list.size()); 103 EXPECT_EQ(1U, list.size());
104 EXPECT_EQ(DevToolsAgentHost::TYPE_WEB_CONTENTS, list[0]->GetType()); 104 EXPECT_EQ(DevToolsAgentHost::TYPE_WEB_CONTENTS, list[0]->GetType());
105 EXPECT_EQ(main_url.spec(), list[0]->GetURL().spec()); 105 EXPECT_EQ(main_url.spec(), list[0]->GetURL().spec());
106 // TODO(dgozman): we should get closed notification here. 106 EXPECT_TRUE(client.closed());
107 // See http://crbug.com/464993.
108 EXPECT_FALSE(client.closed());
109 child_host->DetachClient(); 107 child_host->DetachClient();
110 child_host = nullptr; 108 child_host = nullptr;
111 } 109 }
112 110
113 } // namespace content 111 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698